Show empty policyExpenseChats in LHN just like defaultRooms

src/libs/OptionsListUtils.js

@@ -448,7 +448,13 @@ function getOptions(reports, personalDetails, activeReportID, {
             : '';
 
         const reportContainsIOUDebt = iouReportOwner && iouReportOwner !== currentUserLogin;
-        const shouldFilterReportIfEmpty = !showReportsWithNoComments && report.lastMessageTimestamp === 0 && !isDefaultRoom;
+        const shouldFilterReportIfEmpty = !showReportsWithNoComments && report.lastMessageTimestamp === 0
+
+                // We make exceptions for defaultRooms and policyExpenseChats so we can immediately
+                // highlight them in the LHN when they are created and have no messsages yet. We do
+                // not give archived rooms this exception since they do not need to be higlihted.
+                && !(!ReportUtils.isArchivedRoom(report) && (isDefaultRoom || isPolicyExpenseChat));
+
         const shouldFilterReportIfRead = hideReadReports && report.unreadActionCount === 0;
         const shouldFilterReport = shouldFilterReportIfEmpty || shouldFilterReportIfRead;
         if (report.reportID !== activeReportID
@@ -476,7 +482,7 @@ function getOptions(reports, personalDetails, activeReportID, {
         // Save the report in the map if this is a single participant so we can associate the reportID with the
         // personal detail option later. Individuals should not be associated with single participant
         // policyExpenseChats or chatRooms since those are not people.
-        if (logins.length <= 1 && !ReportUtils.isPolicyExpenseChat(report) && !ReportUtils.isChatRoom(report)) {
+        if (logins.length <= 1 && !isPolicyExpenseChat && !isChatRoom) {
             reportMapForLogins[logins[0]] = report;
         }
         const isSearchingSomeonesPolicyExpenseChat = !report.isOwnPolicyExpenseChat && searchValue !== '';

tests/unit/OptionsListUtilsTest.js

@@ -100,6 +100,37 @@ describe('OptionsListUtils', () => {
             iouReportID: 100,
             hasOutstandingIOU: true,
         },
+
+        // Note: This reoprt is a policyExpenseChat without any messages in it (i.e. no lastMessageTimestamp)
+        10: {
+            chatType: 'policyExpenseChat',
+            hasOutstandingIOU: false,
+            isOwnPolicyExpenseChat: true,
+            isPinned: false,
+            lastMessageTimestamp: 0,
+            lastVisitedTimestamp: 1610666739302,
+            participants: ['test3@instantworkspace.com'],
+            policyID: 'Whatever',
+            reportID: 10,
+            reportName: "Someone's workspace",
+            unreadActionCount: 0,
+            visibility: undefined,
+        },
+
+        // Note: This reoprt is a defaultRoom without any messages in it (i.e. no lastMessageTimestamp)
+        11: {
+            chatType: 'policyAdmins',
+            hasOutstandingIOU: false,
+            isPinned: false,
+            lastMessageTimestamp: 0,
+            lastVisitedTimestamp: 1610666739302,
+            participants: ['test3@instantworkspace.com'],
+            policyID: 'Whatever',
+            reportID: 11,
+            reportName: '#admins',
+            unreadActionCount: 0,
+            visibility: undefined,
+        },
     };
 
     // And a set of personalDetails some with existing reports and some without
@@ -613,7 +644,7 @@ describe('OptionsListUtils', () => {
                 );
 
                 // Then expect all of the reports to be shown both multiple and single participant except the
-                // unpinned report that has no lastMessageTimestamp
+                // unpinned report that has no lastMessageTimestamp and is not a policyExpenseChat or defaultRoom
                 expect(results.recentReports.length).toBe(_.size(reportsWithAddedPinnedMessagelessReport) - 1);
 
                 const numberOfPinnedReports = _.filter(results.recentReports, report => report.isPinned).length;
@@ -643,8 +674,9 @@ describe('OptionsListUtils', () => {
                 const results = OptionsListUtils.getSidebarOptions(REPORTS_WITH_MORE_PINS, PERSONAL_DETAILS, 0, CONST.PRIORITY_MODE.GSD);
 
                 // Then expect all of the reports to be shown both multiple and single participant except the
-                // report that has no lastMessageTimestamp and the chat with Thor who's message is read
-                expect(results.recentReports.length).toBe(_.size(REPORTS_WITH_MORE_PINS) - 2);
+                // report that has no lastMessageTimestamp, the chat with Thor who's message is read, and the
+                // empty PolicyExpenseChats and DefaultRooms
+                expect(results.recentReports.length).toBe(_.size(REPORTS_WITH_MORE_PINS) - 4);
 
                 // That no personalDetails are shown
                 expect(results.personalDetails.length).toBe(0);