Thesahindia/UI/confirmView

[thesahindia]

Details

• Made confirmView component to reuse in confirmModal and confirmPopover
• Made delete confirmModal consistent

Fixed Issues

$ #7545

Tests

• Verify that no errors appear in the JS console

QA Steps

1. Open app
2. Navigate to Settings > Payments and try to delete any payment
3. Navigate to Settings > Workspace and try to delete the workspace
4. Navigate to a chat > Try to delete a comment
5. Verify the confirmModal/Popover is consistent

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

Testing shortly...

[parasharrajat]

LGTM.

@Beamanator

🎀 👀 🎀 C+ reviewed

[parasharrajat]

cc: @Beamanator

[Beamanator]

Thanks @parasharrajat I'll check this out today, I was on vacation last week :D

[Beamanator]

Overall looks great, just a few style changes and comment change suggestion

[Beamanator]

Thanks for the quick edits @thesahindia ! 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Beamanator in version: 1.1.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mvtglobally]

We are still able to repro #7768 in IOS, so limited QA possible. Rest platforms ok

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅