[No QA] Update ESLint version #6583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmax330
requested changes
Dec 6, 2021
madmax330
previously approved these changes
Dec 7, 2021
|
Merge conflicts |
|
Fixed. |
|
@madmax330 ready for you again whenever you have a chance! |
madmax330
approved these changes
Dec 8, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
25 tasks
|
🚀 Deployed to staging by @madmax330 in version: 1.1.18-4 🚀
|
This was referenced Dec 9, 2021
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a follow up to #3133 in which we renamed our custom
TextandButtoncomponents toExpensifyTextandExpensifyButton. In Expensify/eslint-config-expensify#38 I added a rule to our ESLint configuration that throws an error ifText,ButtonorTextInputare imported fromreact-native. This is because we want our custom components used instead.There are a handful of cases where we use
Text,ButtonandTextInputin our code today. To keep this PR focused, I've just added comments in those cases to suppress the lint errors. And I've created follow up issues here and here to look into whether we can refactor those to use ourExpensifyTextandExpensiTextInputcomponents instead.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/187203
Tests
There aren't any changes to user-facing code. Just some comments added and an update of our ESLint version. However, I did click around generally in the app to make sure it still seemed to work.
QA Steps
No QA. There is nothing to test for this specifically.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android