Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Electron ESM draft PR #639

Closed
wants to merge 15 commits into from
Closed

[DRAFT] Electron ESM draft PR #639

wants to merge 15 commits into from

Conversation

roryabraham
Copy link
Contributor

Fixed Issues

Allows us to use ES6 imports in our electron main file

Tests

Just run the desktop app and check for errors. (There are some)

@roryabraham roryabraham self-assigned this Oct 13, 2020
@roryabraham
Copy link
Contributor Author

There is an unresolved error that occurs when running this draft PR:

08:06:37.569 › (node:1700) UnhandledPromiseRejectionWarning: ReferenceError: window is not defined
    at /Users/roryabraham/ReactNativeChat/node_modules/@react-native-community/async-storage/lib/commonjs/AsyncStorage.js:1
    at /Users/roryabraham/ReactNativeChat/node_modules/@react-native-community/async-storage/lib/commonjs/AsyncStorage.js:1
    at new Promise (<anonymous>)
    at createPromise (/Users/roryabraham/ReactNativeChat/node_modules/@react-native-community/async-storage/lib/commonjs/AsyncStorage.js:1)
    at Function.getAllKeys (/Users/roryabraham/ReactNativeChat/node_modules/@react-native-community/async-storage/lib/commonjs/AsyncStorage.js:1)
    at Object.connect (/Users/roryabraham/ReactNativeChat/src/lib/Ion.js:130:18)
    at Object.<anonymous> (/Users/roryabraham/ReactNativeChat/src/lib/checkForUpdates.js:9:5)
    at Generator.next (<anonymous>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant