Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup "Fix language selector" #6274

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Followup "Fix language selector" #6274

merged 1 commit into from
Nov 10, 2021

Conversation

MonilBhavsar
Copy link
Contributor

@MonilBhavsar MonilBhavsar commented Nov 10, 2021

Details

Use withLocalize prop translate function

Fixed Issues

#6267 (comment)

Tests / QA Steps

Same as #6267 (comment)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-11-09 at 12 49 43 PM

Mobile Web

Desktop

iOS

Android

cc @roryabraham

@MonilBhavsar MonilBhavsar requested a review from a team as a code owner November 10, 2021 12:01
@MonilBhavsar MonilBhavsar self-assigned this Nov 10, 2021
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team November 10, 2021 12:01
@marcaaron
Copy link
Contributor

Thanks for the change!

@marcaaron marcaaron merged commit 5498334 into main Nov 10, 2021
@marcaaron marcaaron deleted the monil-fixLanguagePicker branch November 10, 2021 13:59
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants