[No QA] Fix dependency cycles

[marcaaron]

Details

Most of the dependency cycles were added when a change was made to log from within HttpUtils which is pretty low level. My solution for this was to basically just move those logs out of there and into API. API also had a dependency cycle with Log but by moving the API.Log command into the file where Log is initialized instead we can avoid this.

One other step taken here was to simplify the practice of "setting callbacks". Since there are many places where we have a pattern of avoiding dependency cycles by injecting callbacks from outside a module. This works fine, but is a little tedious so I added a utility that works like this:

const [someCallback, registerSomeCallback, cancelSomeCallback] = createCallback();

Fixed Issues

$ #6251

Tests

❌

QA Steps

❌

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[roryabraham]

overall looks pretty good, just had one comment.

[marcaaron]

Taking these changes off HOLD now that I am back from OOO

Almost done with these JS style issues and want to wrap them up before we all start moving to higher priority things :) 🚀

[roryabraham]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @marcaaron in version: 1.1.16-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅