-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Workspace Switcher and Get Assistance Button issues #58000
base: main
Are you sure you want to change the base?
Fix Workspace Switcher and Get Assistance Button issues #58000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! Let's fix Lint and changed lint workflows 🚀
@@ -56,7 +56,6 @@ function ConnectedVerifiedBankAccount({reimbursementAccount, onBackButtonPress, | |||
> | |||
<HeaderWithBackButton | |||
title={translate('workspace.common.connectBankAccount')} | |||
guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_BANK_ACCOUNT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Eslint is failing in this file
I can still reproduce on web browser #57811 : Screen.Recording.2025-03-08.at.09.37.55.mov |
It is no longer reproducible on the current main. Screen.Recording.2025-03-10.at.10.41.37.mov |
Explanation of Change
This pr:
get assistance button
in favor ofHelp Button
Help Button
from Workspace switcherIn line with the comments:
#57808 (comment)
#57811 (comment)
Fixed Issues
$ #57808
$ #57811
PROPOSAL:
Tests
Open Workspace switcher
Verify there is no help button
Open workspaces
Click Invite member
Verify that only help button is visible
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop