Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distance-related fields are missing in split details page #57621

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: distance-related fields are missing in split details page #57621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pages/iou/SplitBillDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ function SplitBillDetailsPage({route, report, reportAction}: SplitBillDetailsPag
const payeePersonalDetails = personalDetails?.[actorAccountID];
const participantsExcludingPayee = participants.filter((participant) => participant.accountID !== reportAction?.actorAccountID);

const isDistanceRequestTransaction = isDistanceRequest(transaction);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isDistanceRequestTransaction = isDistanceRequest(transaction);
const isDistanceRequest = isDistanceRequest(transaction);

NIT: The transaction word looks redundant to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c3024 isDistanceRequest is also the function name so I added the Transaction postfix.

const isScanning = hasReceipt(transaction) && isReceiptBeingScanned(transaction);
const hasSmartScanFailed = hasReceipt(transaction) && transaction?.receipt?.state === CONST.IOU.RECEIPT_STATE.SCANFAILED;
const isEditingSplitBill = session?.accountID === actorAccountID && areRequiredFieldsEmpty(transaction);
Expand Down Expand Up @@ -106,7 +107,7 @@ function SplitBillDetailsPage({route, report, reportAction}: SplitBillDetailsPag
/>
</View>
)}
<ImageBehaviorContextProvider shouldSetAspectRatioInStyle={!isDistanceRequest(transaction)}>
<ImageBehaviorContextProvider shouldSetAspectRatioInStyle={!isDistanceRequestTransaction}>
{!!participants.length && (
<MoneyRequestConfirmationList
payeePersonalDetails={payeePersonalDetails}
Expand All @@ -121,6 +122,7 @@ function SplitBillDetailsPage({route, report, reportAction}: SplitBillDetailsPag
iouIsBillable={splitBillable}
iouType={CONST.IOU.TYPE.SPLIT}
isReadOnly={!isEditingSplitBill}
isDistanceRequest={isDistanceRequestTransaction}
shouldShowSmartScanFields
receiptPath={transaction?.receipt?.source}
receiptFilename={transaction?.filename}
Expand Down
Loading