-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merge account feature to ND #56911
base: main
Are you sure you want to change the base?
Changes from 19 commits
cda8dad
e4bdee3
16d5fdc
ec445e1
06c15e5
717bc14
217ceb4
353a410
e79174a
89ecf4e
61ff190
478de42
20f900e
3281bc5
c2eeb1e
305253c
78a5563
6501b6d
a4800c2
c210eda
9368bec
89f3947
4474019
f4e5d37
6a8d5b8
025b2a0
5b995df
54b1340
c8f1ad0
9cd1765
907e1eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,6 +105,7 @@ import type { | |
ManagerApprovedParams, | ||
MarkedReimbursedParams, | ||
MarkReimbursedFromIntegrationParams, | ||
MergeAccountGenericParams, | ||
MissingPropertyParams, | ||
MovedFromPersonalSpaceParams, | ||
NeedCategoryForExportToIntegrationParams, | ||
|
@@ -1360,6 +1361,62 @@ const translations = { | |
defaultContact: 'Método de contacto predeterminado:', | ||
enterYourDefaultContactMethod: 'Por favor, introduce tu método de contacto predeterminado para cerrar tu cuenta.', | ||
}, | ||
mergeAccountsPage: { | ||
mergeAccount: 'Fusionar cuentas', | ||
accountDetails: { | ||
accountToMergeInto: ({email}: MergeAccountGenericParams) => `Introduce la cuenta en la que deseas fusionar ${email}`, | ||
notReversibleConsent: 'Entiendo que esto no es reversible', | ||
}, | ||
accountValidate: { | ||
confirmMerge: '¿Estás seguro de que deseas fusionar cuentas?', | ||
lossOfUnsubmittedData: ({email}: MergeAccountGenericParams) => `Fusionar tus cuentas es irreversible y resultará en la pérdida de cualquier gasto no enviado de ${email}`, | ||
enterMagicCode: ({email}: MergeAccountGenericParams) => `Para continuar, por favor introduce el código mágico enviado a ${email}`, | ||
}, | ||
mergeSuccess: { | ||
accountsMerged: '¡Cuentas fusionadas!', | ||
successfullyMergedAllData: ({email, newEmail}: MergeAccountGenericParams & {newEmail: string}) => | ||
`Has fusionado exitosamente todos los datos de ${email} en ${newEmail}. De ahora en adelante, puedes usar cualquiera de los inicios de sesión para esta cuenta`, | ||
}, | ||
mergePendingSAML: { | ||
weAreWorkingOnIt: 'Estamos trabajando en ello', | ||
limitedSupport: 'Todavía no es posible fusionar cuentas en New Expensify. Por favor, realiza esta acción en Expensify Classic en su lugar', | ||
reachOutForHelp: { | ||
beforeLink: '¡No dudes en ', | ||
linkText: 'comunicarte con Concierge', | ||
afterLink: ' si tienes alguna pregunta!', | ||
}, | ||
goToExpensifyClassic: 'Dirígete a Expensify Classic', | ||
}, | ||
mergeFailureSAMLDomainControl: { | ||
beforeLink: ({email}: MergeAccountGenericParams) => `No puedes fusionar ${email} porque está controlado por ${email.split('@').at(0)}. Póngase `, | ||
linkText: 'en contacto con Conserjería', | ||
afterLink: ' si necesita ayuda.', | ||
}, | ||
mergeFailureSAMLAccount: ({email}: MergeAccountGenericParams) => | ||
`No puedes fusionar ${email} en otras cuentas porque tu administrador de dominio la ha establecido como tu inicio de sesión principal. Por favor, fusiona otras cuentas en esta en su lugar.`, | ||
mergeFailure2FA: { | ||
oldAccount2FAEnabled: ({email}: MergeAccountGenericParams) => | ||
`No puedes fusionar cuentas porque ${email} tiene habilitada la autenticación de dos factores (2FA). Por favor, deshabilita 2FA para ${email} e inténtalo nuevamente.`, | ||
learnMore: 'Aprende más sobre cómo fusionar cuentas.', | ||
}, | ||
mergeFailureAccountLocked: { | ||
beforeLink: ({email}: MergeAccountGenericParams) => `No puedes fusionar ${email} porque está bloqueado. Póngase `, | ||
linkText: 'en contacto con Conserjería', | ||
afterLink: ` si necesita ayuda.`, | ||
}, | ||
mergeFailureUncreatedAccount: { | ||
noExpensifyAccount: ({email}: MergeAccountGenericParams) => `No puedes fusionar cuentas porque ${email} no tiene una cuenta de Expensify.`, | ||
addContactMethod: { | ||
beforeLink: 'Por favor, ', | ||
linkText: 'añádela como método de contacto', | ||
afterLink: ' en su lugar.', | ||
}, | ||
}, | ||
mergeFailureSmartScannerAccount: ({email}: MergeAccountGenericParams) => `No puedes fusionar ${email} en otras cuentas. Por favor, fusiona otras cuentas en esta en su lugar.`, | ||
mergeFailureInvoicedAccount: ({email}: MergeAccountGenericParams) => | ||
`No puedes fusionar ${email} en otras cuentas porque es el propietario de facturación de una cuenta facturada. Por favor, fusiona otras cuentas en esta en su lugar.`, | ||
mergeFailureGenericHeading: 'No se pueden fusionar cuentas', | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have we confirmed all these? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add link to the slack discussion on checklist. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are in the design doc. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
passwordPage: { | ||
changePassword: 'Cambiar contraseña', | ||
changingYourPasswordPrompt: 'El cambio de contraseña va a afectar tanto a la cuenta de Expensify.com como la de New Expensify.', | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
type GetValidateCodeForAccountMergeParams = {email: string; authToken: string}; | ||
|
||
export default GetValidateCodeForAccountMergeParams; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
type MergeWithValidateCode = {email: string; validateCode: string}; | ||
|
||
export default MergeWithValidateCode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier we are getting away from -1 defaults. So is It a good move? I think we need a discussion for this before adopting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just used it because linter was throwing an error. I'll try changing this to '0' instead.