fix: group chat avatar disappears after adding other members and creating the group #56597

nkdengineer · 2025-02-10T10:02:15Z

Explanation of Change

fix: group chat avatar disappears after adding other members and creating the group

Fixed Issues

$ #56504
PROPOSAL: #56504 (comment)

Tests

Go to FAB > Start chat
Adding some members to group
Upload an avatar
Going back and add some other members
Create the group chat and verify that the group avatar is the uploaded avatar

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Go to FAB > Start chat
Adding some members to group
Upload an avatar
Going back and add some other members
Create the group chat and verify that the group avatar is the uploaded avatar

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-10.at.16.29.23.mov

Android: mWeb Chrome

Screen.Recording.2025-02-10.at.16.27.00.mov

iOS: Native

Screen.Recording.2025-02-10.at.16.42.02.mov

iOS: mWeb Safari

Screen.Recording.2025-02-10.at.16.24.28.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-10.at.16.21.36.mov

MacOS: Desktop

Screen.Recording.2025-02-10.at.16.40.33.mov

…ting the groupd

melvin-bot · 2025-02-10T10:22:09Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-02-10T18:52:51Z

🚧 @Julesssss has triggered a test build. You can view the workflow run here.

Julesssss · 2025-02-10T18:54:37Z

src/pages/NewChatConfirmPage.tsx

@@ -118,9 +119,9 @@ function NewChatConfirmPage() {
        // To handle this, we re-read the avatar image file from disk whenever the component re-mounts.
        readFileAsync(stashedLocalAvatarImage, newGroupDraft?.avatarFileName ?? '', onSuccess, onFailure, newGroupDraft?.avatarFileType ?? '');

-        // we only need to run this when the component re-mounted
+        // we only need to run this when the component re-mounted and when the onyx is loaded completely


Minor change:

// we only need to run this when the component re-mounted and when onyx is loaded completely

github-actions · 2025-02-10T19:17:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56597/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56597/NewExpensify.dmg	https://56597.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2025-02-10T22:23:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screenrecorder-2025-02-10-23-47-03-168.mp4

Android: mWeb Chrome

Screenrecorder-2025-02-10-23-51-49-996.mp4

iOS: Native

2025-02-11.00.03.28.mov

iOS: mWeb Safari

2025-02-10.23.40.24.mp4

MacOS: Chrome / Safari

2025-02-10.23.35.12.mov

MacOS: Desktop

2025-02-10.23.44.36.mov

ZhenjaHorbach · 2025-02-10T23:05:28Z

LGTM !

Julesssss · 2025-02-10T23:10:31Z

Excellent

OSBotify · 2025-02-10T23:19:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: group chat avatar disappears after adding other members and creating the group (cherry picked from commit 5624931) (CP triggered by Julesssss)

github-actions · 2025-02-10T23:49:14Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.95-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-02-11T02:15:56Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: group chat avatar disappears after adding other members and crea…

49f983b

…ting the groupd

nkdengineer marked this pull request as ready for review February 10, 2025 10:22

nkdengineer requested a review from a team as a code owner February 10, 2025 10:22

melvin-bot bot requested review from shubham1206agra and removed request for a team February 10, 2025 10:22

Julesssss added the Ready To Build label Feb 10, 2025

Julesssss reviewed Feb 10, 2025

View reviewed changes

Julesssss approved these changes Feb 10, 2025

View reviewed changes

Julesssss requested review from ZhenjaHorbach and removed request for shubham1206agra February 10, 2025 22:23

ZhenjaHorbach mentioned this pull request Feb 10, 2025

Group chat -Group chat avatar disappears after going back to add more members and create group #56504

Closed

8 tasks

ZhenjaHorbach approved these changes Feb 10, 2025

View reviewed changes

melvin-bot bot requested a review from Julesssss February 10, 2025 23:05

Julesssss merged commit 5624931 into Expensify:main Feb 10, 2025
17 of 19 checks passed

OSBotify pushed a commit that referenced this pull request Feb 10, 2025

Merge pull request #56597 from nkdengineer/fix/56504

ee07d43

fix: group chat avatar disappears after adding other members and creating the group (cherry picked from commit 5624931) (CP triggered by Julesssss)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Feb 10, 2025

github-actions bot mentioned this pull request Feb 10, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: group chat avatar disappears after adding other members and creating the group #56597

fix: group chat avatar disappears after adding other members and creating the group #56597

nkdengineer commented Feb 10, 2025 •

edited

Loading

melvin-bot bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

Julesssss Feb 10, 2025

github-actions bot commented Feb 10, 2025

ZhenjaHorbach commented Feb 10, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 10, 2025

Julesssss commented Feb 10, 2025

OSBotify commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 11, 2025

fix: group chat avatar disappears after adding other members and creating the group #56597

fix: group chat avatar disappears after adding other members and creating the group #56597

Conversation

nkdengineer commented Feb 10, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

Julesssss Feb 10, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 10, 2025

ZhenjaHorbach commented Feb 10, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ZhenjaHorbach commented Feb 10, 2025

Julesssss commented Feb 10, 2025

OSBotify commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 11, 2025

nkdengineer commented Feb 10, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 10, 2025 •

edited

Loading