-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight autocomplete value on a match #56243
Merged
luacmartins
merged 21 commits into
Expensify:main
from
software-mansion-labs:289Adam289/50949-highlight-autocomplete-on-match
Feb 6, 2025
Merged
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0169b8e
Merge branch 'main' into 289Adam289/50949-highlight-autocomplete-on-m…
289Adam289 29f98af
Merge branch 'main' into 289Adam289/50949-highlight-autocomplete-on-m…
289Adam289 0cf5ebb
working highlighting
289Adam289 85d5435
add syntax highlighting
289Adam289 944fbdd
add supporting text
289Adam289 7eb5861
grammar formatting
289Adam289 74cade5
Merge branch 'main' into 289Adam289/50949-highlight-autocomplete-on-m…
289Adam289 68b3262
fix merge
289Adam289 d5acdee
make emailList shared value
289Adam289 068f04c
fix changed files lint
289Adam289 62b1617
fix parser
289Adam289 d0f297d
Merge branch 'main' into 289Adam289/50949-highlight-autocomplete-on-m…
289Adam289 56a5c8d
generate serach parser
289Adam289 568d42f
fix types and remove unnecessary ref
289Adam289 ee8297b
fix tests for autocomplete parser
289Adam289 efb018a
fix types and perf-tests
289Adam289 bf5abe0
Merge branch 'main' into 289Adam289/50949-highlight-autocomplete-on-m…
289Adam289 f56ae47
fix perf tests and changed files lint
289Adam289 3e3221f
fix names and consts
289Adam289 11b4639
improve readability - extract logic from parser
289Adam289 829f608
fix type
289Adam289 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name might be confusing for other developers.
However for now I can't come up with a name better than
SYNTAX_KEY_NAME
. The main problem is that this const is not simply some "syntax key" but the NAME for key representing syntax 😅 which is why I would like it to have a bit longer more descriptive name.If you can't come up with anything better just leave as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
SYNTAX_RANGE_NAME
?