Fix keyboard flickering and bad typing behavior while typing password in revealed state for a protected PDF #55130

rohit9625 · 2025-01-11T20:16:48Z

Explanation of Change

Typing was not smooth while typing the password in the revealed state for protected PDFs. The reason was that the rapidly changing keyboard caused the keyboard to flicker when the password was revealed.

I've removed the getSecureEntryKeyboardType method for native Android, which was forcing keyboard-type='visible-password', which causes the keyboard to flicker.

Fixed Issues

$ #53394
PROPOSAL: $ #53394 (comment)

Tests

Open the Expensify Android app
Open any chat
Tap on the "+" button and select "Add File"
Select a PDF that is protected with a password
Tap on "Enter the password"
Tap on the eye icon to reveal the password
Start typing the password
Make sure keyboard is not flickering and typing is smooth

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

TestOnAndroidApp.mp4

Android: mWeb Chrome

TestOnAndroidChrome.mp4

iOS: Native

TestOnIOSApp.mov

iOS: mWeb Safari

TestOnSafariIOS.1.mov

MacOS: Chrome / Safari

TestOnMacSafari.mov

MacOS: Desktop

TestOnMacDesktopApp.mov

Replaced `getSecureEntryKeyboardType` with direct use of `inputProps.keyboardType` to resolve conflicts between `secureTextEntry` and `keyboardType="visible-password"`

Removed the Android native getSecureTextEntry method as it no longer needed

melvin-bot · 2025-01-11T20:16:53Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-01-11T20:16:53Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-01-11T20:17:02Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

rohit9625 · 2025-01-11T20:19:25Z

I have read the CLA Document and I hereby sign the CLA.

rohit9625 · 2025-01-11T20:19:39Z

recheck

src/libs/getSecureEntryKeyboardType/index.android.ts

rohit9625 · 2025-01-13T10:04:29Z

@jjcoffee I have made the changes. Now, this PR is ready for review :)

jjcoffee · 2025-01-13T10:17:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2025-01-13_11.48.11.mp4

Android: mWeb Chrome

android-chrome-2025-01-13_11.49.45.mp4

iOS: Native

ios-app-2025-01-13_14.13.41.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

desktop-chrome-2025-01-13_11.30.38.mp4

MacOS: Desktop

desktop-app-2025-01-13_11.33.38.mp4

jjcoffee · 2025-01-13T14:19:33Z

@rohit9625 Did you have any issues getting the password-protected PDF to show up on iOS Safari? I just get an endless spinner (it's not an issue with your PR since the same happens on staging and on main).

rohit9625 · 2025-01-13T14:23:09Z

I didn't tried opening the PDF with correct password on IOS Safari.
I have to create another cloud instance to test that if necessary. Should I?

jjcoffee · 2025-01-13T14:40:39Z

@rohit9625 That would be useful, but I'm also asking on Slack. It seems to be happening on production too, which is strange! I'm using iOS 17.2 (also tried with iOS 17.0) and iPhone 15 Pro Max.

rohit9625 · 2025-01-13T14:42:50Z

Okay, let me know if I can do something.

Thanks 😊

jjcoffee

LGTM! The issue I mentioned is limited to iOS 17.2 and not related to this PR.

rafecolton

LGTM, thanks!

rafecolton · 2025-01-13T23:09:07Z

eslint failures do not look related - asked here: https://expensify.slack.com/archives/C01GTK53T8Q/p1736809645567419

rohit9625 · 2025-01-14T02:44:46Z

Why are the performance tests failing? All unit tests passed locally.

Ran all test suites.
✅ Written Baseline performance measurements to .reassure/baseline.perf
🔗 /home/runner/work/App/App/.reassure/baseline.perf

Hint: You can now run 'reassure' to measure & compare performance against modified code.

HEAD is now at 7f074b6 Merge 03f25bd into c98f805
hint: Recursive merging with submodules currently only supports trivial cases.
Auto-merging .eslintrc.changed.js
hint: Please manually handle the merging of each conflicted submodule.
hint: This can be accomplished with the following steps:
hint: - come back to superproject and run:
hint:
hint: git add Mobile-Expensify
hint:
hint: to record the above merge or update
hint: - resolve any other conflicts in the superproject
hint: - commit the resulting index in the superproject
hint:
hint: Disable this message with "git config advice.submoduleMergeConflict false"
Failed to merge submodule Mobile-Expensify (not checked out)
CONFLICT (submodule): Merge conflict in Mobile-Expensify

rafecolton · 2025-01-14T03:33:15Z

It looks like there merge conflicts in the submodule? AFAIK you didn't change that here 🤔 Try merging main, and if that doesn't work, try asking for help via the usual channels

rohit9625 · 2025-01-14T04:54:26Z

I have merged the main branch using GitKraken @rafecolton. I didn't sign the merge commit. Should I --amend -S this commit and force push?

rafecolton · 2025-01-14T07:16:15Z

~~No need 👍~~

rafecolton · 2025-01-14T07:17:18Z

Oh no sorry, I misread. Do please sign your commit 🙏

rohit9625 · 2025-01-14T07:39:32Z

Oh no sorry, I misread. Do please sign your commit 🙏

Okay, Thanks :)

OSBotify · 2025-01-14T08:27:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-14T14:00:35Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T14:16:36Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T14:41:58Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T15:25:39Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T15:49:50Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2025-01-15T13:48:45Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-15T15:49:41Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

rohit9625 added 2 commits January 11, 2025 19:16

fix: remove dynamic keyboardType logic causing keyboard flickering

1810a4c

Replaced `getSecureEntryKeyboardType` with direct use of `inputProps.keyboardType` to resolve conflicts between `secureTextEntry` and `keyboardType="visible-password"`

refactor: remove getSecureTextEntry method

c3bee3d

Removed the Android native getSecureTextEntry method as it no longer needed

rohit9625 requested a review from a team as a code owner January 11, 2025 20:16

melvin-bot bot requested a review from jjcoffee January 11, 2025 20:16

melvin-bot bot removed the request for review from a team January 11, 2025 20:16

CLABotify added a commit to Expensify/CLA that referenced this pull request Jan 11, 2025

@rohit9625 has signed the CLA in Expensify/App#55130

f8d9d73

CyberAndrii reviewed Jan 12, 2025

View reviewed changes

src/libs/getSecureEntryKeyboardType/index.android.ts Show resolved Hide resolved

cleanup: remove redundant getSecureEntryKeyboardType function

03f25bd

jjcoffee approved these changes Jan 13, 2025

View reviewed changes

melvin-bot bot requested a review from rafecolton January 13, 2025 17:15

rafecolton approved these changes Jan 13, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix-keyboard-issue

76ecceb

rohit9625 force-pushed the fix-keyboard-issue branch from fe19a42 to 76ecceb Compare January 14, 2025 07:38

rafecolton merged commit 481d5bb into Expensify:main Jan 14, 2025
15 checks passed

github-actions bot mentioned this pull request Jan 14, 2025

Deploy Checklist: New Expensify 2025-01-14 #55208

Closed

38 tasks

melvin-bot bot mentioned this pull request Jan 15, 2025

[HOLD for payment 2025-01-22] [$250] Android - Attachments - Typing is not smooth when revealing password in protected PDF #53394

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix keyboard flickering and bad typing behavior while typing password in revealed state for a protected PDF #55130

Fix keyboard flickering and bad typing behavior while typing password in revealed state for a protected PDF #55130

rohit9625 commented Jan 11, 2025 •

edited

Loading

melvin-bot bot commented Jan 11, 2025

melvin-bot bot commented Jan 11, 2025

github-actions bot commented Jan 11, 2025 •

edited

Loading

rohit9625 commented Jan 11, 2025

rohit9625 commented Jan 11, 2025

rohit9625 commented Jan 13, 2025

jjcoffee commented Jan 13, 2025 •

edited

Loading

jjcoffee commented Jan 13, 2025

rohit9625 commented Jan 13, 2025

jjcoffee commented Jan 13, 2025

rohit9625 commented Jan 13, 2025

jjcoffee left a comment

rafecolton left a comment

rafecolton commented Jan 13, 2025

rohit9625 commented Jan 14, 2025

rafecolton commented Jan 14, 2025

rohit9625 commented Jan 14, 2025 •

edited

Loading

rafecolton commented Jan 14, 2025 •

edited

Loading

rafecolton commented Jan 14, 2025

rohit9625 commented Jan 14, 2025

OSBotify commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

Fix keyboard flickering and bad typing behavior while typing password in revealed state for a protected PDF #55130

Fix keyboard flickering and bad typing behavior while typing password in revealed state for a protected PDF #55130

Conversation

rohit9625 commented Jan 11, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 11, 2025

melvin-bot bot commented Jan 11, 2025

github-actions bot commented Jan 11, 2025 • edited Loading

rohit9625 commented Jan 11, 2025

rohit9625 commented Jan 11, 2025

rohit9625 commented Jan 13, 2025

jjcoffee commented Jan 13, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Jan 13, 2025

rohit9625 commented Jan 13, 2025

jjcoffee commented Jan 13, 2025

rohit9625 commented Jan 13, 2025

jjcoffee left a comment

Choose a reason for hiding this comment

rafecolton left a comment

Choose a reason for hiding this comment

rafecolton commented Jan 13, 2025

rohit9625 commented Jan 14, 2025

rafecolton commented Jan 14, 2025

rohit9625 commented Jan 14, 2025 • edited Loading

rafecolton commented Jan 14, 2025 • edited Loading

rafecolton commented Jan 14, 2025

rohit9625 commented Jan 14, 2025

OSBotify commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

rohit9625 commented Jan 11, 2025 •

edited

Loading

github-actions bot commented Jan 11, 2025 •

edited

Loading

jjcoffee commented Jan 13, 2025 •

edited

Loading

rohit9625 commented Jan 14, 2025 •

edited

Loading

rafecolton commented Jan 14, 2025 •

edited

Loading