Fix italic font #549
Fix italic font #549
Conversation
package.json
Outdated
| @@ -20,7 +20,8 @@ | |||
| "lint": "eslint .", | |||
| "postinstall": "patch-package", | |||
| "postversion": "react-native-version", | |||
| "print-version": "echo $npm_package_version" | |||
| "print-version": "echo $npm_package_version", | |||
| "link": "react-native link" | |||
There was a problem hiding this comment.
I just added a command to link the resources and in particular the fonts
There was a problem hiding this comment.
So it's my understanding that react native should link things for us: e.g. https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
I have run link before because I was reading old documentation for libraries and it lead to issues compiling iOS/Android. My recommendation would be remove this so people don't use it and break the build, and just use it manually for linking fonts. Maybe you could go one step further and write a stack overflow post on "how to add a custom font to react native"?
There was a problem hiding this comment.
removed and I added the SO here
src/style/StyleSheet.js
Outdated
| // if the style is italic, and iOS won't use italic font if the style is normal, web does care either way. | ||
| // this will probably need some change on the HTML library itself, so for now I'm adding | ||
| // the platform check | ||
| fontStyle: Platform.OS === 'android' ? 'normal' : 'italic', |
There was a problem hiding this comment.
Rather than adding a platform check (which is forbidden), the proper way is to use the platform specific file names. In this case, I would do something like this:
- Add the directory
/src/style/italic/ - Add two files to it
index.js(which exports "italic") andindex.android.js(which exports "normal") - In this file
import italic from './italic'; - and change this reference to
fontStyle: italic,
There was a problem hiding this comment.
that sounds like a excellent solution, I might need something similar for a fix on for bold not working on Android
|
Looking super close! Just one lint error to fix. |
removing the link command;
Changes were made to resolve this 👍
Regarding the breaking change - we're not using SSID information - it doesn't affect us v8 Includes the following fixes: 8.0.0 (2022-02-10) BREAKING CHANGES it's possible this is a breaking change, depending on your app use case. If you relied on iOS SSID information and met Apple's strict criteria for accessing SSID, you need to set the new config value shouldFetchWiFiSSID to true. If you set it to true and do not meet the criteria your app may crash due to a memory leak. All versions prior to 7.1.12 would attempt to fetch the information regardless of permission, leak memory, and possibly crash. This change avoids that crash. Bug Fixes ios: avoid memory leak from ssid APIs by adding explicit config (Expensify#560) (fbf7c15), closes Expensify#420 7.1.11 (2022-02-08) Bug Fixes windows: fix race condition in WiFi connection details feature (Expensify#568) (0cd8132) 7.1.10 (2022-02-07) Bug Fixes android: use registerDefaultNetworkCallback so toggling airplane mode works (Expensify#571) (e8af2de) 7.1.9 (2022-01-26) Bug Fixes android: count native listeners / correctly disable listener if count == 0 (Expensify#569) (5ae16f6) 7.1.8 (2022-01-25) Bug Fixes windows: refactor implementation to avoid crashes (Expensify#564) (cc4bfa3) 7.1.7 (2021-12-20) Bug Fixes android: populate network value during initial module startup (Expensify#553) (c05080f) 7.1.6 (2021-12-13) Bug Fixes android: avoid send event when has no listener (Expensify#548) (cad47d8) 7.1.5 (2021-12-09) Bug Fixes android: use method-local ref to instance var for multi-thread safety Expensify#549 (Expensify#550) (81bbc87) 7.1.4 (2021-12-07) Bug Fixes android: try async state fetch as stale state workaround (Expensify#547) (937cf48), closes Expensify#542
fixes: https://github.com/Expensify/Expensify/issues/141857
Problem
Italic fonts needed to be added.
Tests
gand comment in normal style, also with agghelps because this letter is very specific to this font.