Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badly positioned screen with autofocus #53699

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Fix badly positioned screen with autofocus #53699

Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f30f900
Fix badly posiotioned screen with autofocus
jnowakow Dec 6, 2024
824baba
Merge branch 'main' into fix-badly-positioned-screen-with-input
jnowakow Dec 9, 2024
ff8e077
Merge branch 'main' into fix-badly-positioned-screen-with-input
jnowakow Dec 10, 2024
e02a770
Fix crash when navigating to not existing chat
jnowakow Dec 10, 2024
3d81a3a
Merge branch 'main' into fix-badly-positioned-screen-with-input
jnowakow Dec 16, 2024
013d471
Merge branch 'main' into fix-badly-positioned-screen-with-input
jnowakow Dec 17, 2024
eeba989
Merge branch 'main' into fix-badly-positioned-screen-with-input
jnowakow Dec 17, 2024
09d288f
Workaround for keyboard issue
jnowakow Dec 17, 2024
497c365
Don't add unnecessary effects
jnowakow Dec 17, 2024
d0af9d7
Merge branch 'main' into fix-badly-positioned-screen-with-input
jnowakow Dec 17, 2024
8f6fbfc
Use getPlatform instead Platform.OS
jnowakow Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/Composer/implementation/index.native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import mimeDb from 'mime-db';
import type {ForwardedRef} from 'react';
import React, {useCallback, useEffect, useMemo, useRef} from 'react';
import type {NativeSyntheticEvent, TextInput, TextInputChangeEventData, TextInputPasteEventData} from 'react-native';
import {StyleSheet} from 'react-native';
import {Platform, StyleSheet} from 'react-native';
import type {FileObject} from '@components/AttachmentModal';
import type {ComposerProps} from '@components/Composer/types';
import type {AnimatedMarkdownTextInputRef} from '@components/RNMarkdownTextInput';
Expand Down Expand Up @@ -140,7 +140,11 @@ function Composer(
textAlignVertical="center"
style={[composerStyle, maxHeightStyle]}
markdownStyle={markdownStyle}
autoFocus={autoFocus}
// /*
// There are cases in hybird app on android that screen goes up when there is autofocus on keyboard. (e.g. https://github.com/Expensify/App/issues/53185)
// Workaround for this issue is to maunally focus keyboard after it's acutally rendered which is done by useAutoFocusInput hook.
// */
autoFocus={Platform.OS !== 'android' ? autoFocus : false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnowakow Because we already used useAutoFocusInput, could we remove this line?

Suggested change
autoFocus={Platform.OS !== 'android' ? autoFocus : false}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this line iOS doesn't work. It's quite strange issue

ios-without-autofocus.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnowakow Thanks. It doesn't work on IOS only. I think it relates to this problem: facebook/react-native#47576

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it may be this problem

/* eslint-disable-next-line react/jsx-props-no-spreading */
{...props}
readOnly={isDisabled}
Expand Down
Loading