-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Tooltip for workspace chat #45390
Merged
deetergp
merged 47 commits into
Expensify:main
from
tienifr:feature/tooltip-for-workspace-chat
Aug 7, 2024
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
cc1ee1f
feature: align tooltip by anchorAlignment on web
tienifr f6c3290
make anchorAlignment work on native
tienifr dfbda8d
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 404a3a7
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr cfd72f1
apply tooltip to lhn row
tienifr 16f1bc0
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 73d1599
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 8353e39
add copy and icon
tienifr a0a183d
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr e26e63c
hide tooltip when navigate
tienifr da051d6
fix test & perf
tienifr c8829de
revert: apply tooltip to lhn row
tienifr 5de4ac7
implement tooltip ui
tienifr 6b8e66c
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 578834f
add nvp
tienifr 6c3ad40
hide tooltip when press add or navigate to other pages
tienifr 7440641
update Spanish copy
tienifr 84e49a1
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 0051bf1
dismiss tooltip
tienifr 1c9b6c8
refactor shouldShow logic
tienifr 7b204cb
hide tooltip on navigating
tienifr 5a671d4
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 1d1599e
fix: tooltip position on safari is incorrect when the page is transit…
tienifr 99fc8bc
fix lint
tienifr 4a79980
define shift in variables
tienifr be30303
export type
tienifr 12a7df6
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 6bf01c9
get onyx workspaceTooltip
tienifr ed6c7ed
fix: navigation object couldn't be found
tienifr af719c9
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr fdacac4
rename resetSuggestions to onPress
tienifr 27fd8dd
implement press anywhere to dismiss tooltip
tienifr 5c4b812
fix tooltip position on native
tienifr 0591c4c
add comments
tienifr 78d43b8
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 8c8cd2d
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr 04c4751
fix: android tooltip broken
tienifr 63be42d
fix: wrong tooltip position for animated parents
tienifr def069f
revert the FullWindowOverlay approach
tienifr a5d35b0
QAB
tienifr f6a013c
fix lint
tienifr 602bec7
delay measure
tienifr bef2353
fix: composer flickers when tap to hide tooltip
tienifr 4b6d7e4
fix lint
tienifr a79ad14
Merge branch 'main' of https://github.com/tienifr/App into feature/to…
tienifr d106777
polish settimeout callback
tienifr b83cb82
fix lint
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teleport the portal to the modal layer, otherwise, the tooltip in any modal/popover would be obscured by that modal. For example the tooltip for QAB.