fix If we alter transaction details, new message green line disappears #43162

tienifr · 2024-06-06T09:26:46Z

Details

Fixed Issues

$ #41211
PROPOSAL: #41211 (comment)

Tests

Launch app
Tap on a report with more than one expense
Tap on a expense
Enter merchant and save it
Mark as unread the system message displayed for entering merchant
Note green line with new message tag above system message
Now edit the merchant and save it
Verify the green line with new message tag above system message does not disappear

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-06.at.16.37.55.mov

Android: mWeb Chrome

Screen.Recording.2024-06-06.at.16.54.49.mov

iOS: Native

Screen.Recording.2024-06-06.at.16.46.23.mov

iOS: mWeb Safari

Screen.Recording.2024-06-06.at.16.52.01.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-06.at.16.29.01.mov

MacOS: Desktop

Screen.Recording.2024-06-06.at.16.34.03.mov

melvin-bot · 2024-06-06T09:26:50Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-06-10T07:44:30Z

@rushatgabhane Can you help review this PR?

rushatgabhane · 2024-06-11T14:12:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

a

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-07-08.at.10.10.51.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-07-08.at.07.40.18.mov

MacOS: Desktop

tienifr · 2024-06-14T02:53:12Z

@rushatgabhane Bump to review this PR

rushatgabhane

@tienifr im unable to mark it as unread. No green line indicator shows up

Screen.Recording.2024-06-16.at.11.28.13.mov

rushatgabhane

Bug: Switching chat and coming back doesn't clear the unread indicator

Send a message to transaction
Mark it as unread
Switch chat and come back

Screen.Recording.2024-06-16.at.11.30.46.mov

tienifr · 2024-06-17T11:19:19Z

Bug: Switching chat and coming back doesn't clear the unread indicator

@rushatgabhane I can reproduce this bug in latest main as well, so I think it is not related to our PR. But I am investigating the RCA of that bug.

fix the back-end to return the same (lastVisibleActionCreated and lastReadTime should be the same and equal to the modified expense's report action created time)

@srikarparsi Can we make that change in BE as well?

srikarparsi · 2024-06-17T18:14:45Z

Hi, yes I can do that. Is that blocking progress or are you able to work around it?

tienifr · 2024-06-17T19:13:39Z

@srikarparsi

Is that blocking progress

The code changes are complete. I just want to test the pull request after the backend is fixed to ensure there are no regressions.

srikarparsi · 2024-06-17T20:26:32Z

Cool sounds good, can you send me a screenshot of the response for which the lastVisibleActionCreated and lastReadTime should be the same to make sure we're on the same page?

tienifr · 2024-06-19T22:07:55Z

@srikarparsi Here is the video:

Screen.Recording.2024-06-20.at.05.06.55.mov

tienifr · 2024-06-24T11:05:19Z

@srikarparsi Any update here?

srikarparsi · 2024-06-24T15:40:22Z

Hey @tienifr, not yet. I'll try to get to this one tomorrow

srikarparsi · 2024-06-26T06:23:21Z

Created the PR for the backend change and it's being reviewed.

Result screenshot where lastReadTime equals lastVisibleActionCreated:

tienifr · 2024-06-26T10:05:15Z

Thanks @srikarparsi. Please ping me once it is merged.

srikarparsi · 2024-06-27T00:38:19Z

Hey @tienifr, the backend PR has been deployed. Let me know if it works with this PR. You should see an additional Onyx update for the lastReadTime as in this screenshot.

tienifr · 2024-06-27T09:24:17Z

@srikarparsi @rushatgabhane I tested again and it works well.

tienifr · 2024-07-02T08:49:21Z

@rushatgabhane Friendly bump to review PR again.

rushatgabhane · 2024-07-08T03:17:15Z

woopss

rushatgabhane · 2024-07-08T03:17:33Z

yayy backend is ready, reviewing

rushatgabhane · 2024-07-08T04:39:34Z

Note that in latest main, marking as unread doesn't show green marker for system message

OSBotify · 2024-07-09T03:21:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-10T11:19:11Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:36:25Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2024-07-10T21:28:02Z

This PR is failing because of issue #41211

The issue is reproducible in:
Android

1720636449179.Screenrecorder-2024-07-10-21-27-52-625.mp4

IOS

1720618337485.43162_iOS.mp4

srikarparsi · 2024-07-10T23:17:40Z

Hi @tienifr @rushatgabhane, can you take a look at this? It looks to have been working in the screen recordings but I just tested on my device on staging and the bug is still reproducible.

rushatgabhane · 2024-07-10T23:24:38Z

interesting... hey it's not blocking anything right?

@tienifr we can continue working on this for native platform and raise a follow up PR?

rushatgabhane · 2024-07-10T23:25:07Z

and yes it's weird. i remember this working fine
the code is also platform agnostic

OSBotify · 2024-07-11T10:16:40Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-11T10:36:16Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

tienifr · 2024-07-15T07:33:37Z

Will re-test the bug on native platform today.

OSBotify · 2024-07-15T20:18:32Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr · 2024-07-16T18:00:13Z

I cannot reproduce the bug anymore in latest main:

Screen.Recording.2024-07-17.at.00.58.14.mov

What about you @rushatgabhane?

OSBotify · 2024-07-17T00:17:55Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix If we alter transaction details, new message green line disappears

12dc2c6

tienifr requested a review from a team as a code owner June 6, 2024 09:26

melvin-bot bot removed the request for review from a team June 6, 2024 09:26

melvin-bot bot requested a review from rushatgabhane June 6, 2024 09:26

tienifr mentioned this pull request Jun 6, 2024

[$250] Android - Chat - If we alter transaction details, new message green line disappears #41211

Closed

6 tasks

rushatgabhane suggested changes Jun 16, 2024

View reviewed changes

fix merge main

748ffec

fix merge main

c7fc9ab

rushatgabhane approved these changes Jul 8, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi July 8, 2024 08:43

srikarparsi approved these changes Jul 9, 2024

View reviewed changes

srikarparsi merged commit 7b558ef into Expensify:main Jul 9, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 10, 2024

Deploy Checklist: New Expensify 2024-07-10 #45144

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix If we alter transaction details, new message green line disappears #43162

fix If we alter transaction details, new message green line disappears #43162

tienifr commented Jun 6, 2024 •

edited

Loading

melvin-bot bot commented Jun 6, 2024

tienifr commented Jun 10, 2024

rushatgabhane commented Jun 11, 2024 •

edited

Loading

tienifr commented Jun 14, 2024

rushatgabhane left a comment •

edited

Loading

rushatgabhane left a comment

tienifr commented Jun 17, 2024

srikarparsi commented Jun 17, 2024

tienifr commented Jun 17, 2024

srikarparsi commented Jun 17, 2024

tienifr commented Jun 19, 2024

tienifr commented Jun 24, 2024

srikarparsi commented Jun 24, 2024

srikarparsi commented Jun 26, 2024 •

edited

Loading

tienifr commented Jun 26, 2024

srikarparsi commented Jun 27, 2024

tienifr commented Jun 27, 2024

tienifr commented Jul 2, 2024

rushatgabhane commented Jul 8, 2024

rushatgabhane commented Jul 8, 2024

rushatgabhane commented Jul 8, 2024

OSBotify commented Jul 9, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 10, 2024

kbecciv commented Jul 10, 2024

srikarparsi commented Jul 10, 2024

rushatgabhane commented Jul 10, 2024

rushatgabhane commented Jul 10, 2024 •

edited

Loading

OSBotify commented Jul 11, 2024

OSBotify commented Jul 11, 2024

tienifr commented Jul 15, 2024

OSBotify commented Jul 15, 2024

tienifr commented Jul 16, 2024

OSBotify commented Jul 17, 2024

fix If we alter transaction details, new message green line disappears #43162

fix If we alter transaction details, new message green line disappears #43162

Conversation

tienifr commented Jun 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 6, 2024

tienifr commented Jun 10, 2024

rushatgabhane commented Jun 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

tienifr commented Jun 14, 2024

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane left a comment

Choose a reason for hiding this comment

tienifr commented Jun 17, 2024

srikarparsi commented Jun 17, 2024

tienifr commented Jun 17, 2024

srikarparsi commented Jun 17, 2024

tienifr commented Jun 19, 2024

tienifr commented Jun 24, 2024

srikarparsi commented Jun 24, 2024

srikarparsi commented Jun 26, 2024 • edited Loading

tienifr commented Jun 26, 2024

srikarparsi commented Jun 27, 2024

tienifr commented Jun 27, 2024

tienifr commented Jul 2, 2024

rushatgabhane commented Jul 8, 2024

rushatgabhane commented Jul 8, 2024

rushatgabhane commented Jul 8, 2024

OSBotify commented Jul 9, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 10, 2024

kbecciv commented Jul 10, 2024

srikarparsi commented Jul 10, 2024

rushatgabhane commented Jul 10, 2024

rushatgabhane commented Jul 10, 2024 • edited Loading

OSBotify commented Jul 11, 2024

OSBotify commented Jul 11, 2024

tienifr commented Jul 15, 2024

OSBotify commented Jul 15, 2024

tienifr commented Jul 16, 2024

OSBotify commented Jul 17, 2024

tienifr commented Jun 6, 2024 •

edited

Loading

rushatgabhane commented Jun 11, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

srikarparsi commented Jun 26, 2024 •

edited

Loading

rushatgabhane commented Jul 10, 2024 •

edited

Loading