-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle focus after edit report item #42965
handle focus after edit report item #42965
Conversation
Hi @rojiphil, The PR is ready to review |
requestAnimationFrame(() => { | ||
reportScrollManager.scrollToIndex(index, true); | ||
}); | ||
}); | ||
reportScrollManager.scrollToIndex(index, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to call scrollToIndex
here again even after calling within requestAnimationFrame
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah we don't need to call this function, I'll remove now thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rojiphil I have updated and re-test
Screen.Recording.2024-06-03.at.20.54.13.mov
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari42965-web-safari-001.mp4Android: Native42965-android-native-001.mp4Android: mWeb Chrome42965-mweb-chrome-001.mp4iOS: Native42965-ios-native-001.mp4iOS: mWeb Safari42965-mweb-safari-001.mp4MacOS: Desktop42965-desktop-001.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suneox Just one small request for change. In the tests
section, please change the wording of the expected behavior to the following as that would help QA:
Verify that the page auto-scrolls to the bottom and the compose box is fully visible without manual scroll.
Otherwise, code LGTM. Tests well and completed checklist too.
Thank you, I have updated |
Hi @thienlnam have you got any feedback on this PR? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
…edit-last-message" This reverts commit 747fe19.
Details
Fixed Issues
$ #40767
PROPOSAL: #40767 (comment)
Tests
Verify that the page auto-scrolls to the bottom and the compose box is fully visible without manual scroll.
Offline tests
QA Steps
Verify that the page auto-scrolls to the bottom and the compose box is fully visible without manual scroll.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-06-02.at.16.04.21.mov
Android: mWeb Chrome
Screen.Recording.2024-06-02.at.16.02.34.mov
iOS: Native
Screen.Recording.2024-06-02.at.15.26.54.mov
iOS: mWeb Safari
Screen.Recording.2024-06-02.at.15.51.31.mov
MacOS: Chrome / Safari
Screen.Recording.2024-06-02.at.15.58.14.mov
MacOS: Desktop
Screen.Recording.2024-06-02.at.16.05.52.mov