[Xero] [Export Flow] Create the Bank account select page #41916

mananjadhav · 2024-05-09T13:59:19Z

Details

Fixed Issues

$ #39745
PROPOSAL:

Tests

Precondition:

Workspace with Xero connection and has Bank accounts.

Test steps

Go to Workspace > Accounting > Export > Xero bank account
Verify that you see the accounts from the Xero Bank accounts list.
Click on any bank account.
Verify It displays the correct bank account name under Xero bank account in Export page.

Verify that no errors appear in the JS console

Offline tests

Same as Test Steps

QA Steps

Same as Test Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-xero-export-bank-account.mov

Android: mWeb Chrome

mweb-chrome-xero-export-bank-account.mov

iOS: Native

ios-xero-export-bank-account.mov

iOS: mWeb Safari

mweb-safari-xero-export-bank-account.mov

MacOS: Chrome / Safari

web-xero-export-bank-account.mov

MacOS: Desktop

desktop-xero-export-bank-account.mov

melvin-bot · 2024-05-09T14:26:03Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote · 2024-05-09T14:38:49Z

@pecanoro could we please have the spanish translation for this:

xeroBankAccountDescription: 'Select the bank account expenses will be posted to as bank transactions.',

Link to the line in the PR: https://github.com/Expensify/App/pull/41916/files#diff-472528060691374654a2e2e866547d385eec3849efddca38cbfca1e5b3ba47d5R2079

ishpaul777 · 2024-05-09T14:41:33Z

@mananjadhav @lakchote Can you help me with steps for the precondition

Workspace with Xero connection and has Bank accounts.

mananjadhav · 2024-05-09T15:27:40Z

@ishpaul777 You'll need to enable the Accounting and Xero beta for this. You can check the steps here.

src/languages/es.ts

mananjadhav · 2024-05-10T10:24:17Z

@ishpaul777 Did you get the access working? Need to move this faster along.

…into xero-export-bank-account-new

mananjadhav · 2024-05-10T10:47:43Z

@pecanoro The Spanish translation is updated (screenshot added to the PR body as well).

mananjadhav · 2024-05-10T10:53:18Z

Asking @hungvu193 to review as per this. Need this for the Xero adhoc build.

ishpaul777 · 2024-05-10T10:54:24Z

Hey @mananjadhav, Sorry for delay, I was not able to priortize yesterday, will try the steps now let you know if i am able to setup in few minutes 🙇

mananjadhav · 2024-05-10T10:55:22Z

Hey @mananjadhav, Sorry for delay, I was not able to priortize yesterday, will try the steps now let you know if i am able to setup in few minutes 🙇

Thanks for responding. Just asked @hungvu193 to review. They already have the setup as well as the context. But sure try and let me know.

ishpaul777 · 2024-05-10T11:15:00Z

I was able to setup Xero 🎉 Just confirming by "account that has Bank Accounts" you mean the bank plaid bank account in new dot right ?

mananjadhav · 2024-05-10T11:32:58Z

No. Means a Xero account with Bank names.

ishpaul777 · 2024-05-10T11:33:04Z

Oh nvm, I see a option to create a demo organisation with Bank account on Xero

ishpaul777 · 2024-05-10T11:38:22Z

src/pages/workspace/accounting/xero/export/XeroBankAccountSelectPage.tsx

+    const xeroSelectorOptions = useMemo<SelectorType[]>(
+        () =>
+            (bankAccounts ?? []).map(({id, name}) => ({
+                value: id,
+                text: name,
+                keyForList: id,
+                isSelected: nonReimbursableAccount === id,
+            })),
+        [nonReimbursableAccount, bankAccounts],
+    );


Hmm i see posibility that there can be a possibility when there is no bank account to choose from, should we show a empty state desgin in this case ?

@lakchote Can confirm this. We didn't add it in other screens so I've kept it as is.

ishpaul777 · 2024-05-10T11:45:25Z

Only one comment so far, Looks good to me otherwise 👍

@mananjadhav Do you want me to fill in checklist? (or we are waiting for a review from @hungvu193) ?

hungvu193

Looking good. Only 2 small comments 👍

hungvu193 · 2024-05-10T14:47:51Z

src/pages/workspace/accounting/xero/export/XeroBankAccountSelectPage.tsx

+
+    const initiallyFocusedOptionKey = useMemo(() => xeroSelectorOptions?.find((mode) => mode.isSelected)?.keyForList, [xeroSelectorOptions]);
+
+    const updateMode = useCallback(


We probably need a more understandable function name 😄

Suggested change

const updateMode = useCallback(

const updateBankAccount = useCallback(

hungvu193 · 2024-05-10T14:49:12Z

src/pages/workspace/accounting/xero/export/XeroBankAccountSelectPage.tsx

+                    nonReimbursableAccount: value,
+                });
+            }
+            Navigation.goBack(ROUTES.POLICY_ACCOUNTING_XERO_ADVANCED.getRoute(policyID));


Suggested change

Navigation.goBack(ROUTES.POLICY_ACCOUNTING_XERO_ADVANCED.getRoute(policyID));

Navigation.goBack(ROUTES.POLICY_ACCOUNTING_XERO_EXPORT.getRoute(policyID));

mananjadhav · 2024-05-10T18:30:28Z

Thanks for the important redirect bug. I had my commits messed up, could've easily missed this one.

hungvu193

LGTM 😄

mananjadhav · 2024-05-11T06:59:33Z

@hungvu193 @ishpaul777 Can one of you please complete the checklist for this one?

ishpaul777 · 2024-05-11T07:03:44Z

I can, in few minutes 😄

ishpaul777 · 2024-05-11T07:57:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-11.at.1.57.05.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-05-11.at.1.59.44.PM.mov

iOS: Native

Screen.Recording.2024-05-11.at.1.42.42.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-11.at.1.46.13.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-11.at.1.37.52.PM.mov

MacOS: Desktop

Screen.Recording.2024-05-11.at.2.03.01.PM.mov

lakchote · 2024-05-13T07:55:30Z

@mananjadhav there are conflicts that need to be solved

mananjadhav · 2024-05-13T08:16:31Z

I’ll resolve them in a few hours.

…into xero-export-bank-account-new

mananjadhav · 2024-05-13T09:41:51Z

Running prettier diff.

mananjadhav · 2024-05-13T09:43:25Z

Fixed lint issues. All checks should pass now.

OSBotify · 2024-05-15T10:15:14Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-23T00:00:15Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

feat: added export bank account page

788b3f6

mananjadhav changed the base branch from main to xero-merge-freeze May 9, 2024 13:59

mananjadhav changed the title ~~Xero export bank account new~~ [Xero] [Export Flow] Create the Bank account select page May 9, 2024

refactor: prettier fix

df25bf8

mananjadhav marked this pull request as ready for review May 9, 2024 14:25

mananjadhav requested a review from a team as a code owner May 9, 2024 14:25

melvin-bot bot requested review from ishpaul777 and removed request for a team May 9, 2024 14:26

pecanoro requested changes May 9, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

mananjadhav added 2 commits May 10, 2024 16:10

Merge branch 'xero-merge-freeze' of https://github.com/Expensify/App …

3265864

…into xero-export-bank-account-new

fix: es change

e085711

ishpaul777 reviewed May 10, 2024

View reviewed changes

hungvu193 suggested changes May 10, 2024

View reviewed changes

fix: route

727a62f

mananjadhav requested a review from hungvu193 May 10, 2024 18:32

hungvu193 approved these changes May 11, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote May 11, 2024 01:38

ishpaul777 approved these changes May 11, 2024

View reviewed changes

pecanoro approved these changes May 12, 2024

View reviewed changes

Merge branch 'xero-merge-freeze' of https://github.com/Expensify/App …

f376d95

…into xero-export-bank-account-new

lakchote approved these changes May 13, 2024

View reviewed changes

style: prettier fix

a905b59

lakchote merged commit ab5c3de into Expensify:xero-merge-freeze May 13, 2024
14 checks passed

github-actions bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

ishpaul777 mentioned this pull request Jun 11, 2024

[Wave Collect] [Xero] [Export Flow] Create the Bank account select page #39745

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Xero] [Export Flow] Create the Bank account select page #41916

[Xero] [Export Flow] Create the Bank account select page #41916

mananjadhav commented May 9, 2024 •

edited

Loading

melvin-bot bot commented May 9, 2024

lakchote commented May 9, 2024

ishpaul777 commented May 9, 2024

mananjadhav commented May 9, 2024

mananjadhav commented May 10, 2024

mananjadhav commented May 10, 2024

mananjadhav commented May 10, 2024

ishpaul777 commented May 10, 2024

mananjadhav commented May 10, 2024 •

edited

Loading

ishpaul777 commented May 10, 2024

mananjadhav commented May 10, 2024

ishpaul777 commented May 10, 2024

ishpaul777 May 10, 2024 •

edited

Loading

mananjadhav May 10, 2024

ishpaul777 commented May 10, 2024 •

edited

Loading

hungvu193 left a comment

hungvu193 May 10, 2024

hungvu193 May 10, 2024

mananjadhav commented May 10, 2024

hungvu193 left a comment

mananjadhav commented May 11, 2024

ishpaul777 commented May 11, 2024

ishpaul777 commented May 11, 2024 •

edited

Loading

lakchote commented May 13, 2024

mananjadhav commented May 13, 2024

mananjadhav commented May 13, 2024

mananjadhav commented May 13, 2024

OSBotify commented May 15, 2024

OSBotify commented May 23, 2024


		const initiallyFocusedOptionKey = useMemo(() => xeroSelectorOptions?.find((mode) => mode.isSelected)?.keyForList, [xeroSelectorOptions]);

		const updateMode = useCallback(

	const updateMode = useCallback(
	const updateBankAccount = useCallback(

	Navigation.goBack(ROUTES.POLICY_ACCOUNTING_XERO_ADVANCED.getRoute(policyID));
	Navigation.goBack(ROUTES.POLICY_ACCOUNTING_XERO_EXPORT.getRoute(policyID));

[Xero] [Export Flow] Create the Bank account select page #41916

[Xero] [Export Flow] Create the Bank account select page #41916

Conversation

mananjadhav commented May 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 9, 2024

lakchote commented May 9, 2024

ishpaul777 commented May 9, 2024

mananjadhav commented May 9, 2024

mananjadhav commented May 10, 2024

mananjadhav commented May 10, 2024

mananjadhav commented May 10, 2024

ishpaul777 commented May 10, 2024

mananjadhav commented May 10, 2024 • edited Loading

ishpaul777 commented May 10, 2024

mananjadhav commented May 10, 2024

ishpaul777 commented May 10, 2024

ishpaul777 May 10, 2024 • edited Loading

Choose a reason for hiding this comment

mananjadhav May 10, 2024

Choose a reason for hiding this comment

ishpaul777 commented May 10, 2024 • edited Loading

hungvu193 left a comment

Choose a reason for hiding this comment

hungvu193 May 10, 2024

Choose a reason for hiding this comment

hungvu193 May 10, 2024

Choose a reason for hiding this comment

mananjadhav commented May 10, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

mananjadhav commented May 11, 2024

ishpaul777 commented May 11, 2024

ishpaul777 commented May 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

lakchote commented May 13, 2024

mananjadhav commented May 13, 2024

mananjadhav commented May 13, 2024

mananjadhav commented May 13, 2024

OSBotify commented May 15, 2024

OSBotify commented May 23, 2024

mananjadhav commented May 9, 2024 •

edited

Loading

mananjadhav commented May 10, 2024 •

edited

Loading

ishpaul777 May 10, 2024 •

edited

Loading

ishpaul777 commented May 10, 2024 •

edited

Loading

ishpaul777 commented May 11, 2024 •

edited

Loading