-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][TS migration] migrate workflow tests #38491
Merged
mountiny
merged 16 commits into
Expensify:main
from
software-mansion-labs:@szymczak/migrate-workflow-tests
Apr 2, 2024
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5d56fb0
migrate jest.config
SzymczakJ 94702fb
migrate testBuild
SzymczakJ d6aefab
migrate validateGithubActions
SzymczakJ 9c18645
migrate verifyPodfile
SzymczakJ fe4547d
migrate verifySignedCommits
SzymczakJ c6f9af1
fix babel not formatting test files
SzymczakJ d886ff2
Merge branch 'main' into @szymczak/migrate-workflow-tests
SzymczakJ e80c43d
fix typescript errors
SzymczakJ 7d176db
Merge branch 'main' into @szymczak/migrate-workflow-tests
SzymczakJ f0fe698
fix mock types
SzymczakJ fd2b2b5
fix pr comments
SzymczakJ 56aca75
merge main
SzymczakJ ad69176
Merge branch 'main' into @szymczak/migrate-workflow-tests
SzymczakJ c45f367
Merge branch 'main' into @szymczak/migrate-workflow-tests
SzymczakJ 6df0fe8
fix type errors
SzymczakJ 95c70e8
fix pr comments
SzymczakJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/* eslint-disable @typescript-eslint/naming-convention */ | ||
import type {Config} from 'jest'; | ||
|
||
const config: Config = { | ||
verbose: true, | ||
transform: { | ||
'^.+\\.(js|jsx|ts|tsx)$': 'ts-jest', | ||
}, | ||
clearMocks: true, | ||
resetMocks: true, | ||
}; | ||
|
||
export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
/* eslint-disable @typescript-eslint/naming-convention */ | ||
import type {StepIdentifier} from '@kie/act-js/build/src/step-mocker/step-mocker.types'; | ||
import {createMockStep} from '../utils/utils'; | ||
|
||
// verify | ||
|
@@ -11,7 +12,7 @@ const VALIDATEGITHUBACTIONS__VERIFY__STEP_MOCKS = [ | |
VALIDATEGITHUBACTIONS__VERIFY__SETUP_NODE__STEP_MOCK, | ||
VALIDATEGITHUBACTIONS__VERIFY__VERIFY_JAVASCRIPT_ACTION_BUILDS__STEP_MOCK, | ||
VALIDATEGITHUBACTIONS__VERIFY__VALIDATE_ACTIONS_AND_WORKFLOWS__STEP_MOCK, | ||
] as const; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
] as const satisfies StepIdentifier[]; | ||
|
||
export { | ||
// eslint-disable-next-line import/prefer-default-export | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove as const? Those arrays aren't supposed to be modified, so that's fine in this file.
UPDATE: it's been causing erorrs, because it lacked
satisfies StepIdentifier[]