[No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,19 @@ | ||
| import {fireEvent, screen} from '@testing-library/react-native'; | ||
| import type {ComponentType} from 'react'; | ||
| import Onyx from 'react-native-onyx'; | ||
| import {measurePerformance} from 'reassure'; | ||
| import type {WithNavigationFocusProps} from '@components/withNavigationFocus'; | ||
| import type Navigation from '@libs/Navigation/Navigation'; | ||
| import ComposeProviders from '@src/components/ComposeProviders'; | ||
| import {LocaleContextProvider} from '@src/components/LocaleContextProvider'; | ||
| import OnyxProvider from '@src/components/OnyxProvider'; | ||
| import {WindowDimensionsProvider} from '@src/components/withWindowDimensions'; | ||
| import * as Localize from '@src/libs/Localize'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import ReportActionsList from '@src/pages/home/report/ReportActionsList'; | ||
| import {ReportAttachmentsProvider} from '@src/pages/home/report/ReportAttachmentsContext'; | ||
| import {ActionListContext, ReactionListContext} from '@src/pages/home/ReportScreenContext'; | ||
| import variables from '@src/styles/variables'; | ||
| import * as LHNTestUtils from '../utils/LHNTestUtils'; | ||
| import PusherHelper from '../utils/PusherHelper'; | ||
| import * as ReportTestUtils from '../utils/ReportTestUtils'; | ||
|
|
@@ -19,8 +22,8 @@ import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatch | |
|
|
||
| const mockedNavigate = jest.fn(); | ||
|
|
||
| jest.mock('@src/components/withNavigationFocus', () => (Component: ComponentType<WithNavigationFocusProps>) => { | ||
| function WithNavigationFocus(props: WithNavigationFocusProps) { | ||
|
|
||
| return ( | ||
| <Component | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
|
|
@@ -40,16 +43,15 @@ jest.mock('@react-navigation/native', () => { | |
| return { | ||
| ...actualNav, | ||
| useRoute: () => mockedNavigate, | ||
| } as typeof Navigation; | ||
| }); | ||
|
|
||
| jest.mock('@src/components/ConfirmedRoute.tsx'); | ||
|
|
||
| beforeAll(() => | ||
| Onyx.init({ | ||
| keys: ONYXKEYS, | ||
| safeEvictionKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS], | ||
| }), | ||
| ); | ||
|
|
||
|
|
@@ -60,7 +62,7 @@ afterAll(() => { | |
| const mockOnLayout = jest.fn(); | ||
| const mockOnScroll = jest.fn(); | ||
| const mockLoadChats = jest.fn(); | ||
| const mockRef = {current: null, flatListRef: null, scrollPosition: null, setScrollPosition: () => {}}; | ||
|
|
||
| // Initialize the network key for OfflineWithFeedback | ||
| beforeEach(() => { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,19 +1,26 @@ | ||||||||
| import type {StackNavigationProp} from '@react-navigation/stack'; | ||||||||
| import {fireEvent, screen, waitFor} from '@testing-library/react-native'; | ||||||||
| import type {ComponentType} from 'react'; | ||||||||
| import React from 'react'; | ||||||||
| import Onyx from 'react-native-onyx'; | ||||||||
| import type Animated from 'react-native-reanimated'; | ||||||||
| import {measurePerformance} from 'reassure'; | ||||||||
| import type {WithNavigationFocusProps} from '@components/withNavigationFocus'; | ||||||||
| import type Navigation from '@libs/Navigation/Navigation'; | ||||||||
| import type {RootStackParamList} from '@libs/Navigation/types'; | ||||||||
| import ComposeProviders from '@src/components/ComposeProviders'; | ||||||||
| import DragAndDropProvider from '@src/components/DragAndDrop/Provider'; | ||||||||
| import {LocaleContextProvider} from '@src/components/LocaleContextProvider'; | ||||||||
| import OnyxProvider from '@src/components/OnyxProvider'; | ||||||||
| import {CurrentReportIDContextProvider} from '@src/components/withCurrentReportID'; | ||||||||
| import {KeyboardStateProvider} from '@src/components/withKeyboardState'; | ||||||||
| import {WindowDimensionsProvider} from '@src/components/withWindowDimensions'; | ||||||||
| import CONST from '@src/CONST'; | ||||||||
| import * as Localize from '@src/libs/Localize'; | ||||||||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||||||||
| import {ReportAttachmentsProvider} from '@src/pages/home/report/ReportAttachmentsContext'; | ||||||||
| import ReportScreen from '@src/pages/home/ReportScreen'; | ||||||||
| import type * as OnyxTypes from '@src/types/onyx'; | ||||||||
| import createCollection from '../utils/collections/createCollection'; | ||||||||
| import createPersonalDetails from '../utils/collections/personalDetails'; | ||||||||
| import createRandomPolicy from '../utils/collections/policies'; | ||||||||
|
|
@@ -24,17 +31,24 @@ import * as TestHelper from '../utils/TestHelper'; | |||||||
| import waitForBatchedUpdates from '../utils/waitForBatchedUpdates'; | ||||||||
| import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatchedUpdates'; | ||||||||
|
|
||||||||
| type ReportScreenWrapperArg = { | ||||||||
| navigation: StackNavigationProp<RootStackParamList>; | ||||||||
| }; | ||||||||
|
|
||||||||
| jest.mock('react-native-reanimated', () => { | ||||||||
| const actualNav = jest.requireActual('react-native-reanimated/mock'); | ||||||||
| return { | ||||||||
| ...actualNav, | ||||||||
| useSharedValue: jest.fn, | ||||||||
| useAnimatedStyle: jest.fn, | ||||||||
| useAnimatedRef: jest.fn, | ||||||||
| } as typeof Animated; | ||||||||
| }); | ||||||||
|
|
||||||||
| jest.mock('@src/components/ConfirmedRoute.tsx'); | ||||||||
|
|
||||||||
| jest.mock('@src/components/withNavigationFocus', () => (Component: ComponentType<WithNavigationFocusProps>) => { | ||||||||
| function WithNavigationFocus(props: WithNavigationFocusProps) { | ||||||||
|
|
||||||||
| return ( | ||||||||
| <Component | ||||||||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||||||||
|
|
@@ -49,7 +63,7 @@ jest.mock('../../src/components/withNavigationFocus', () => (Component) => { | |||||||
| return WithNavigationFocus; | ||||||||
| }); | ||||||||
|
|
||||||||
| jest.mock('@src/hooks/useEnvironment', () => | ||||||||
| jest.fn(() => ({ | ||||||||
| environment: 'development', | ||||||||
| environmentURL: 'https://new.expensify.com', | ||||||||
|
|
@@ -58,13 +72,13 @@ jest.mock('../../src/hooks/useEnvironment', () => | |||||||
| })), | ||||||||
| ); | ||||||||
|
|
||||||||
| jest.mock('@src/libs/Permissions', () => ({ | ||||||||
| canUseLinkPreviews: jest.fn(() => true), | ||||||||
| canUseDefaultRooms: jest.fn(() => true), | ||||||||
| })); | ||||||||
| jest.mock('@src/hooks/usePermissions.ts'); | ||||||||
|
|
||||||||
| jest.mock('@src/libs/Navigation/Navigation'); | ||||||||
|
|
||||||||
| const mockedNavigate = jest.fn(); | ||||||||
| jest.mock('@react-navigation/native', () => { | ||||||||
|
|
@@ -81,7 +95,7 @@ jest.mock('@react-navigation/native', () => { | |||||||
| addListener: () => jest.fn(), | ||||||||
| }), | ||||||||
| createNavigationContainerRef: jest.fn(), | ||||||||
| } as typeof Navigation; | ||||||||
| }); | ||||||||
|
|
||||||||
| // mock PortalStateContext | ||||||||
|
|
@@ -91,13 +105,12 @@ beforeAll(() => | |||||||
| Onyx.init({ | ||||||||
| keys: ONYXKEYS, | ||||||||
| safeEvictionKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS], | ||||||||
| }), | ||||||||
| ); | ||||||||
|
|
||||||||
| // Initialize the network key for OfflineWithFeedback | ||||||||
| beforeEach(() => { | ||||||||
| global.fetch = TestHelper.getGlobalFetchMock() as typeof fetch; | ||||||||
|
There was a problem hiding this comment.
Suggested change
It would be better to just suppress the error and comment that we need to remove the comment once |
||||||||
| wrapOnyxWithWaitForBatchedUpdates(Onyx); | ||||||||
| Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); | ||||||||
| }); | ||||||||
|
|
@@ -109,18 +122,18 @@ afterEach(() => { | |||||||
| }); | ||||||||
|
|
||||||||
| const policies = createCollection( | ||||||||
| (item: OnyxTypes.Policy) => `${ONYXKEYS.COLLECTION.POLICY}${item.id}`, | ||||||||
| (index: number) => createRandomPolicy(index), | ||||||||
| 10, | ||||||||
| ); | ||||||||
|
|
||||||||
| const personalDetails = createCollection( | ||||||||
| (item: OnyxTypes.PersonalDetails) => item.accountID, | ||||||||
| (index: number) => createPersonalDetails(index), | ||||||||
| 20, | ||||||||
| ); | ||||||||
|
|
||||||||
| function ReportScreenWrapper(args: ReportScreenWrapperArg) { | ||||||||
|
There was a problem hiding this comment.
Suggested change
Shouldn't be props? |
||||||||
| return ( | ||||||||
| <ComposeProviders | ||||||||
| components={[ | ||||||||
|
|
@@ -136,6 +149,7 @@ function ReportScreenWrapper(args) { | |||||||
| <ReportScreen | ||||||||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||||||||
| {...args} | ||||||||
| // @ts-expect-error TODO: Remove this once ReportScreen is migrated to TypeScript. | ||||||||
|
|
||||||||
| navigation={args.navigation} | ||||||||
| /> | ||||||||
| </ComposeProviders> | ||||||||
|
|
@@ -147,6 +161,7 @@ const reportActions = ReportTestUtils.getMockedReportActionsMap(500); | |||||||
| const mockRoute = {params: {reportID: '1'}}; | ||||||||
|
|
||||||||
| test('[ReportScreen] should render ReportScreen with composer interactions', () => { | ||||||||
| // @ts-expect-error TODO: Remove this once TestHelper (https://github.com/Expensify/App/issues/25318) is migrated to TypeScript. | ||||||||
| const {triggerTransitionEnd, addListener} = TestHelper.createAddListenerMock(); | ||||||||
| const scenario = async () => { | ||||||||
| /** | ||||||||
|
|
@@ -196,6 +211,7 @@ test('[ReportScreen] should render ReportScreen with composer interactions', () | |||||||
| .then(() => | ||||||||
| measurePerformance( | ||||||||
| <ReportScreenWrapper | ||||||||
| // @ts-expect-error TODO: Remove this once ReportScreen is migrated to TypeScript. | ||||||||
| navigation={navigation} | ||||||||
| route={mockRoute} | ||||||||
| />, | ||||||||
|
|
@@ -205,6 +221,7 @@ test('[ReportScreen] should render ReportScreen with composer interactions', () | |||||||
| }); | ||||||||
|
|
||||||||
| test('[ReportScreen] should press of the report item', () => { | ||||||||
| // @ts-expect-error TODO: Remove this once TestHelper (https://github.com/Expensify/App/issues/25318) is migrated to TypeScript. | ||||||||
| const {triggerTransitionEnd, addListener} = TestHelper.createAddListenerMock(); | ||||||||
| const scenario = async () => { | ||||||||
| /** | ||||||||
|
|
@@ -245,6 +262,7 @@ test('[ReportScreen] should press of the report item', () => { | |||||||
| .then(() => | ||||||||
| measurePerformance( | ||||||||
| <ReportScreenWrapper | ||||||||
| // @ts-expect-error TODO: Remove this once ReportScreen is migrated to TypeScript. | ||||||||
|
There was a problem hiding this comment. Let's add a link as well
Suggested change
|
||||||||
| navigation={navigation} | ||||||||
| route={mockRoute} | ||||||||
| />, | ||||||||
|
|
||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this should be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @VickyStash explained the reason here: #37820 (comment)