feat: Workflow payer page #37629

ishpaul777 · 2024-03-01T18:55:56Z

Details

Fixed Issues

$ #37197
PROPOSAL: n/a

Tests

Verify that no errors appear in the JS console
Precondition user should have paid policy setup and user is admin

Navigate to workspace/<id>/workflows, toggle on/off this option make sure it persists after refresh.

If workspace not has VBA account setup , verify it should only show connect bank account option.

if workspace has VBA setup it should also show option to choose authorized payer.

Click on authorized payer selector, verify it should show list of all admins and owner of the workspace
Select a admin as authorized and verify that it should show as authorized payer and persist after refresh.

Failing Scenario tests:

Turn on simulate failing request in About > Troubleshoot.
Choose a authorized payer again and wait till the request fails to add authorized payer.
verify red dot appears on the menu item and a error message is shown below it.

Offline tests

Go offline and Try to toggle on/off the this option, verify opacity is 50% when user offline

Try to add a authorized payer, when the user is offline this menuitem should have 50% opacity

QA Steps

Verify that no errors appear in the JS console

same as tests and offline tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-12.at.9.46.58.PM-1.mov

Android: mWeb Chrome

Screen.Recording.2024-03-12.at.5.13.45.AM.mov

iOS: Native

Screen.Recording.2024-03-11.at.5.17.06.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-03-11.at.4.57.07.PM.mov

MacOS: Desktop

Screen.Recording.2024-03-12.at.9.55.02.PM-1.mov

src/languages/en.ts

melvin-bot · 2024-03-04T14:28:39Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-03-04T14:41:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2024-03-12_16.02.45.mp4

Android: mWeb Chrome

android-chrome-2024-03-12_15.52.39.mp4

iOS: Native

ios-native-2024-03-12_15.36.20.mp4

iOS: mWeb Safari

ios-safari-2024-03-12_15.43.43.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-03-11_15.09.12.mp4

MacOS: Desktop

desktop-app-2024-03-12_14.43.10.mp4

shawnborton · 2024-03-12T15:33:34Z

Those look good to me!

shawnborton · 2024-03-12T15:34:09Z

But i seee the standard is the is 12px margin right for all the dot indicator error messages, we are not controlling this yet, its the standard but we def. can control it now.

Ah, if we are using 12px gap everywhere, then I say let's just stick with that for now.

jjcoffee · 2024-03-12T16:09:06Z

Looking pretty good now, I think! The only thing is my concern here, I'll let @luacmartins make the last call on that.

ishpaul777 · 2024-03-12T16:09:24Z

@jjcoffee if changes looks good to you i'l proceed with the final videos. would be great if we can get this merged today..

ishpaul777 · 2024-03-12T16:10:14Z

ahh.. we commented on same time

jjcoffee

EOD for me now so I'll approve in order to keep this moving! We're just pending the rest of the test videos from @ishpaul777.

ishpaul777 · 2024-03-12T16:30:17Z

Added the videos... 😀

luacmartins · 2024-03-12T17:05:20Z

I think we can address this one as a follow up. I'll create an issue for it.

melvin-bot · 2024-03-12T17:07:41Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-03-12T17:10:39Z

Issue created here - #38153

luacmartins · 2024-03-12T17:27:53Z

Tests passed when I merged.

OSBotify · 2024-03-12T18:50:06Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-13T19:45:21Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx

jjcoffee · 2024-04-04T08:07:54Z

src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

-                    />
+                    <>
+                        <MenuItem
+                            titleStyle={styles.textLabelSupportingNormal}


We needed to display the default label in a different font size here. Fixed in #38584

ishpaul777 added 2 commits March 2, 2024 00:23

adds workflow payer page

9f10186

fixes scrollins issue and adds submenuitem for payer

6492353

ishpaul777 changed the title ~~[WIP] feat: Workflow payer page~~ feat: Workflow payer page Mar 1, 2024

ishpaul777 and others added 6 commits March 2, 2024 00:39

Merge branch 'main' into workflow/payer

bbefc40

fixes type error

3bc8478

fix failing tests

f5bcfa5

fixes type errors

5ac67c2

fixes conflicts with mail

b9e0dc0

basic structure for payer page

927aacc

luacmartins self-requested a review March 1, 2024 21:08

ishpaul777 and others added 8 commits March 2, 2024 03:16

toggle setWorkspaceReimbursement v1

654e080

adds section list for payerpage

81d0698

fixes crash for ios

58ebe8c

Merge branch 'Expensify:main' into workflow/payer

90b959c

fixes lint issue and add api command

d7a55d5

fixes offline behaviour and offline behaviour

cd83702

fixes option toggle on/off

03b63c0

fixes bank account fetch logic

4c3bd57

ishpaul777 commented Mar 4, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

ishpaul777 added 4 commits March 4, 2024 19:14

resolve lint

6618475

remove unused type

99f932c

fix error indicator for menu item

0cb874c

prettier diffs

a5c5ed9

ishpaul777 marked this pull request as ready for review March 4, 2024 14:28

ishpaul777 requested a review from a team as a code owner March 4, 2024 14:28

melvin-bot bot requested review from jjcoffee and removed request for a team March 4, 2024 14:28

fixes copy for the error

2356983

ishpaul777 added 2 commits March 12, 2024 21:30

remove unnecessary changes

2215017

lint fix

7db1690

ishpaul777 requested a review from luacmartins March 12, 2024 16:10

jjcoffee approved these changes Mar 12, 2024

View reviewed changes

luacmartins approved these changes Mar 12, 2024

View reviewed changes

luacmartins merged commit 5a5dfcb into Expensify:main Mar 12, 2024
16 of 23 checks passed

melvin-bot bot added the Emergency label Mar 12, 2024

luacmartins mentioned this pull request Mar 12, 2024

[HOLD for payment 2024-04-05] [$500] [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present #38153

Closed

luacmartins removed the Emergency label Mar 12, 2024

github-actions bot mentioned this pull request Mar 12, 2024

Deploy Checklist: New Expensify 2024-03-12 #38162

Closed

84 tasks

izarutskaya mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-04-03] [Wave Collect] [Workflows] Unable to toggle Make or track payments #38206

Closed

6 tasks

Beamanator mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-03-22] [$500] Authorized payer - Enter key does not select another member as authorized payer #38203

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-03-20] [Wave8] [Simplified Collect] [Workflows] Create Payment page #37197

Closed

ikevin127 mentioned this pull request Mar 14, 2024

[Wave Collect] [Workflows] Authorized payer - Admin list is blank if Members tab is not visited before #38290

Closed

6 tasks

jjcoffee reviewed Mar 20, 2024

View reviewed changes

src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx Show resolved Hide resolved

ishpaul777 mentioned this pull request Mar 21, 2024

Prevent full screen loading on Workflows page if data is present #38428

Merged

50 tasks

jjcoffee reviewed Apr 4, 2024

View reviewed changes

jjcoffee mentioned this pull request Apr 4, 2024

[$250] [HOLD for payment 2024-04-03] [Simplified Collect] [Workflows] Connect bank account label is too small in Workspace > Workflows #38584

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Workflow payer page #37629

feat: Workflow payer page #37629

ishpaul777 commented Mar 1, 2024 •

edited

Loading

melvin-bot bot commented Mar 4, 2024

jjcoffee commented Mar 4, 2024 •

edited

Loading

shawnborton commented Mar 12, 2024

shawnborton commented Mar 12, 2024

jjcoffee commented Mar 12, 2024

ishpaul777 commented Mar 12, 2024

ishpaul777 commented Mar 12, 2024

jjcoffee left a comment

ishpaul777 commented Mar 12, 2024

luacmartins commented Mar 12, 2024

melvin-bot bot commented Mar 12, 2024

luacmartins commented Mar 12, 2024

luacmartins commented Mar 12, 2024

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

jjcoffee Apr 4, 2024

feat: Workflow payer page #37629

feat: Workflow payer page #37629

Conversation

ishpaul777 commented Mar 1, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 4, 2024

jjcoffee commented Mar 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

shawnborton commented Mar 12, 2024

shawnborton commented Mar 12, 2024

jjcoffee commented Mar 12, 2024

ishpaul777 commented Mar 12, 2024

ishpaul777 commented Mar 12, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

ishpaul777 commented Mar 12, 2024

luacmartins commented Mar 12, 2024

melvin-bot bot commented Mar 12, 2024

luacmartins commented Mar 12, 2024

luacmartins commented Mar 12, 2024

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

jjcoffee Apr 4, 2024

Choose a reason for hiding this comment

ishpaul777 commented Mar 1, 2024 •

edited

Loading

jjcoffee commented Mar 4, 2024 •

edited

Loading