Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IOU description can't be seen on the LHN reports #34840

Merged
merged 27 commits into from
Mar 19, 2024

Conversation

tobyjsullivan
Copy link
Contributor

@tobyjsullivan tobyjsullivan commented Jan 19, 2024

Details

Update the translation iou.payerOwesAmount to include the IOU description when it is available.

Fixed Issues

$ #31859
PROPOSAL: #31859 (comment)

Tests

Steps to Reproduce

  1. Navigate to https://dev.new.expensify.com:8082/
  2. Click avatar at top of LHN to open "Settings"
  3. Click "Preferences"
  4. Set "Priority mode" to "Most recent"
  5. Click the FAB to open menu.
  6. Click "Request Money".
  7. Select "Manual" entry.
  8. Enter amount of 5000 and click "Next".
  9. Enter email for another member and click the suggestion.
  10. Enter a description (e.g., "Ramen dinner")
  11. Click "Request $5000.00" to create the IOU
  12. Find the IOU report in LHN for one of the members.
  13. Verify the description is included in the report preview in the LHN.

Tests

  1. Size window to full-size. Observe the IOU description is included in the LHN on desktop view.
    • Note: if the email address is too long, this can be verified by inspecting the element in Chrome dev tools.
  2. Resize screen to mobile size, click back arrow to view LHN. Observe description appears on IOU report.
  3. Verify that no errors appear in the JS console.
  4. Create a new split IOU with no description. Confirm the LHN record displays the amount without a description.
  5. Split the IOU between multiple members.
  6. Edit the amount of an IOU.

Offline tests

  1. Throttle network (in Chrome dev tools).
  2. Ensure LHN still renders correctly.

QA Steps

Steps to Reproduce

  1. Navigate to https://staging.new.expensify.com/
  2. Sign into an account with a workspace
  3. Click avatar at top of LHN to open "Settings"
  4. Click "Preferences"
  5. Set "Priority mode" to "Most recent"
  6. Click the FAB to open menu.
  7. Click "Request Money".
  8. Select "Manual" entry.
  9. Enter amount of 5000 and click "Next".
  10. Enter email for another member and click the suggestion.
  11. Enter a description (e.g., "Ramen dinner")
  12. Click "Request $5000.00" to create the IOU
  13. Find the IOU report in LHN for one of the members.
  14. Verify the report subtitle includes the description.
    • You may need to resize the browser window to mobile size to see the full description (see screenshots below for examples)

Tests

  • Size window to full-size. Observe the IOU description is included in the LHN on desktop view.
    • Note: if the email address is too long, this can be verified by inspecting the element in Chrome dev tools.
  • Resize screen to mobile size, click back arrow to view LHN. Observe description appears on IOU report.
  • Verify that no errors appear in the JS console.
  • Create a new IOU with no description. Confirm the LHN record displays the amount without a description.
  • Split the request between multiple members.
  • Edit the amount of the money request and verify the description is updated.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a [High Traffic account]
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Note: change is not actually visible on Android. However, tests confirm no functionality is broken.

Expensify.31859.-.Test.006.-.Android.mov
Android: mWeb Chrome

Note: change is not actually visible on Android. However, tests confirm no functionality is broken.

Expensify.31859.-.Test.007.-.mWeb.Android.mov
iOS: Native

Note: change is not actually visible on iOS. However, tests confirm no functionality is broken.

Expensify.31859.-.Test.003.-.iOS.mov
iOS: mWeb Safari

Note: change is not actually visible on iOS. However, tests confirm no functionality is broken.

Expensify.31859.-.Test.004.-.mWeb.iOS.mov
MacOS: Chrome / Safari
Expensify.31859.-.Test.002.mov

image

MacOS: Desktop
Expensify.31859.-.Test.005.-.Desktop.macOS.mov

Copy link
Contributor

github-actions bot commented Jan 19, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tobyjsullivan
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@tobyjsullivan tobyjsullivan marked this pull request as ready for review January 22, 2024 18:57
@tobyjsullivan tobyjsullivan requested a review from a team as a code owner January 22, 2024 18:57
@melvin-bot melvin-bot bot requested review from parasharrajat and removed request for a team January 22, 2024 18:57
Copy link

melvin-bot bot commented Jan 22, 2024

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dangrous
Copy link
Contributor

hey @parasharrajat! Do you have time to take a look at this today? Thanks!

@parasharrajat
Copy link
Member

I will get on it.

Comment on lines 1934 to 1936
const reportTransactions = !isEmptyObject(report) ? TransactionUtils.getAllReportTransactions(report.reportID) : [];
const comment = reportTransactions.length === 1 ? TransactionUtils.getDescription(reportTransactions[0]) : undefined;
return Localize.translateLocal('iou.payerOwesAmount', {payer: payerOrApproverName, amount: formattedAmount, comment});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have to change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is being updated to include the description from money requests.

Copy link
Member

@parasharrajat parasharrajat Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't understand the question. I am asking why we have to change this part of the code. Do we need to pass comment here to solve the issue? What does it change in UI?

-- Please reply to all three comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for the clarification. Re-reading the discussion on the original issue, I think I misunderstood this comment.

Correct, let's change the existing one and adjust it where used.

I originally interpreted this to mean we should include the description everywhere the translation is used. However, now I see that's not what you meant. Instead, you meant we can use the same translation everywhere and other places would not need to change.

I can revert the changes to these blocks. Please confirm if that's the preferred course of action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, correct. I would also suggest to check if we are not missing this comment anywhere else. For now, let's remove these updates where comments should not be shown. For example this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've reverted changes to all the text unrelated to the original issue.

const comment = !isEmptyObject(transaction) ? TransactionUtils.getDescription(transaction) : undefined;
messageText = Localize.translateLocal('iou.payerOwesAmount', {payer, amount: formattedAmount, comment});
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for these. Why do we have to change these chunks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous code used a ternary operation to select which translation is used, then the same parameters were passed in either case.

Now, the iou.payerOwesAmount translation is being updated to accept a description from money requests. As a result, the translations no longer accept the same parameters and the previous ternary branch is no longer an option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for the clarification. Re-reading the discussion on the original issue, I think I misunderstood this comment.

Correct, let's change the existing one and adjust it where used.

I originally interpreted this to mean we should include the description everywhere the translation is used. However, now I see that's not what you meant. Instead, you meant we can use the same translation everywhere and other places would not need to change.

I can revert the changes to these blocks. Please confirm if that's the preferred course of action.

Comment on lines 2276 to 2285
const payer = ReportUtils.getPersonalDetailsForAccountID(updatedMoneyRequestReport.managerID).login || '';
const formattedAmount = CurrencyUtils.convertToDisplayString(updatedMoneyRequestReport.total, updatedMoneyRequestReport.currency);
let messageText;
if (hasNonReimbursableTransactions) {
messageText = Localize.translateLocal('iou.payerSpentAmount', {payer, amount: formattedAmount});
} else {
const comment = TransactionUtils.getDescription(updatedTransaction);
messageText = Localize.translateLocal('iou.payerOwesAmount', {payer, amount: formattedAmount, comment});
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for these. Why do we have to change these chunks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous code used a ternary operation to select which translation is used, then the same parameters were passed in either case.

Now, the iou.payerOwesAmount translation is being updated to accept a description from money requests. As a result, the translations no longer accept the same parameters and the previous ternary branch is no longer an option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for the clarification. Re-reading the discussion on the original issue, I think I misunderstood this comment.

Correct, let's change the existing one and adjust it where used.

I originally interpreted this to mean we should include the description everywhere the translation is used. However, now I see that's not what you meant. Instead, you meant we can use the same translation everywhere and other places would not need to change.

I can revert the changes to these blocks. Please confirm if that's the preferred course of action.

@tobyjsullivan
Copy link
Contributor Author

Updated

@parasharrajat
Copy link
Member

OK, so I noticed one issue. Your PR works great for split requests.

There are a few types of chat in the app.

  1. DM
  2. Group Chat.
  3. 1-1 money report.
  4. 1-Many split money report. (this also creates 1-1 money report between all the users and the request is sent as a message to each DM between these users).

You fixed the issue for DM between users when we split among users but the issue is still present for 1-1 money report.

Here in the below image, you can see that split chat report has description but it is not present not for request report between two users.

In the image,
DM = 1-1 money report.
Group Split = 1-Many split money report.

Screenshot 2024-01-30 at 1 09 33 PM

@tobyjsullivan
Copy link
Contributor Author

@parasharrajat Okay, good call. I've pushed a commit which adds the comment for that translation.

I can see in the code that there are other cases that probably need a translation (namely, ${name} spent ${amount}). However, I cannot figure out how to get these cases to show in the UI. Do you know what case would put that in the LHN or should I leave that alone for now?

@tobyjsullivan
Copy link
Contributor Author

Updated

@parasharrajat
Copy link
Member

@tobyjsullivan Could you please merge main?

@parasharrajat
Copy link
Member

I will check it shortly. Thanks for your patience.

@@ -2296,6 +2296,7 @@ function getReportPreviewMessage(
isPreviewMessageForParentChatReport = false,
policy: OnyxEntry<Policy> = null,
isForListPreview = false,
originalReportAction: OnyxEntry<ReportAction> | EmptyObject = reportAction,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to understand the difference between this and reportAction. Can you please describe this?

Copy link
Contributor Author

@tobyjsullivan tobyjsullivan Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct that they are very similar but there is one case where the values differ.

In general, reportAction should be the message for which the preview is being generated. However, a different action is passed for reportAction when generating the LHN message for a report preview (a message grouping multiple money requests - see screenshot below for an example).

} else if (ReportActionUtils.isReportPreviewAction(lastReportAction)) {
const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastReportAction));
const lastIOUMoneyReportAction = allSortedReportActions[iouReport?.reportID ?? '']?.find(
(reportAction, key) =>
ReportActionUtils.shouldReportActionBeVisible(reportAction, key) &&
reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
ReportActionUtils.isMoneyRequestAction(reportAction),
);
lastMessageTextFromReport = ReportUtils.getReportPreviewMessage(
!isEmptyObject(iouReport) ? iouReport : null,
lastIOUMoneyReportAction,
true,
ReportUtils.isChatReport(report),
null,
true,
);

I believe this is a bug and should be fixed separately.

To generate the correct preview text for a report preview action, we need a way to access the original preview action so that we can determine the number of child reports in the preview. To solve this, I pass the original as originalReportAction while leaving reportAction unchanged. (Fixing the value of reportAction would blow out the scope of this PR, particularly around QA/validation, so I've decided not to do that.)

Visual Example

Here is an example of a "report preview" message. In this case, reportAction should be the last message (the only message, in this particular case). However, in practice, reportAction is one of the child money request reports. To correct for this, the actual preview message is passed as originalReportAction.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename the reportAction param to previewReportAction to make it more clear. Also add a comment explaining the differences between both on the definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, done with one tweak. I renamed reportAction to iouReportAction as I think this will be less confusing to readers. Hopefully the comments clarify why this name makes sense.

Copy link
Member

@parasharrajat parasharrajat Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. But I don't think that the previous reportAction was only an iOU report action. It can be linked to a normal DM as well. Why do you think iouReportAction is better name?

Copy link
Contributor Author

@tobyjsullivan tobyjsullivan Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous comment suggested reportAction could be either a report preview or an IOU report action so perhaps that comment is incorrect.

* @param [reportAction] This can be either a report preview action or the IOU action

I did not want to rename reportAction to previewReportAction because that name implies the action is a report preview. This would be confusing because the value is never a report preview action (as far as I can tell).

I chose iouReportAction because it seemed the report action could only be an IOU report action. However, if that's not true and it can also be a normal DM, then I no longer believe iouReportAction is the better name.

Do you still consider previewReportAction to be the correct choice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good. I think the action can only be an iOU report action or an iou Preview Action.

@tobyjsullivan
Copy link
Contributor Author

Updated

@parasharrajat
Copy link
Member

parasharrajat commented Mar 11, 2024

r### Screenshots

🔲 iOS / native

Screen.Recording.2024-03-12.at.3.10.26.PM.mov

🔲 iOS / Safari

Screen.Recording.2024-03-12.at.3.14.15.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2024-03-12.at.3.15.12.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2024-03-11.at.5.19.22.PM.mov

🔲 Android / Chrome

Screen.Recording.2024-03-12.at.3.09.07.PM.mov

🔲 Android / native

Screen.Recording.2024-03-12.at.3.06.16.PM.mov

@parasharrajat
Copy link
Member

parasharrajat commented Mar 11, 2024

Just waiting on the iOS Build error PR so that I can finish the checklist.

@parasharrajat
Copy link
Member

@tobyjsullivan Please merge main so that I can test iOS.

@tobyjsullivan
Copy link
Contributor Author

Updated

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@melvin-bot melvin-bot bot requested a review from dangrous March 12, 2024 09:49
@parasharrajat
Copy link
Member

parasharrajat commented Mar 12, 2024

There is a bug with the Send Money flow where clicking the description shows not found page. This is also present on staging not related to this PR.

Reported: https://expensify.slack.com/archives/C049HHMV9SM/p1710239078914799

dangrous
dangrous previously approved these changes Mar 12, 2024
Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this works for me!

@dangrous
Copy link
Contributor

Blargh can you try merging main and see if that fixes those performance tests? thanks!

@dangrous
Copy link
Contributor

Bump the above ^ @tobyjsullivan - would like to get this merged this week. Thanks!

@parasharrajat
Copy link
Member

@dangrous Ready for review.

@tobyjsullivan
Copy link
Contributor Author

Thanks for the nudge. I'd missed that request. Latest main is merged in now.

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dangrous dangrous merged commit 73ecb3f into Expensify:main Mar 19, 2024
16 checks passed
@melvin-bot melvin-bot bot added the Emergency label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

@dangrous looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/dangrous in version: 1.4.55-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/dangrous in version: 1.4.55-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants