[TS Migration] Migrate FlagCommentPage #34734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VickyStash
reviewed
Jan 22, 2024
src/pages/FlagCommentPage.tsx
Outdated
Comment on lines
31
to
33
| type FlagCommentPageProps = WithReportAndReportActionOrNotFoundProps & FlagCommentPageWithOnyxProps; | ||
|
|
||
| type FlagCommentRouteProp = RouteProp<{params: {reportID: string; reportActionID: string}}>; |
There was a problem hiding this comment.
I think you will also need to update WithReportAndReportActionOrNotFoundProps type
Suggested change
| type FlagCommentPageProps = WithReportAndReportActionOrNotFoundProps & FlagCommentPageWithOnyxProps; | |
| type FlagCommentRouteProp = RouteProp<{params: {reportID: string; reportActionID: string}}>; | |
| type FlagCommentPageNavigationProps = StackScreenProps<FlagCommentNavigatorParamList, typeof SCREENS.FLAG_COMMENT_ROOT>; | |
| type FlagCommentPageProps = WithReportAndReportActionOrNotFoundProps & FlagCommentPageWithOnyxProps & FlagCommentPageNavigationProps; |
src/pages/FlagCommentPage.tsx
Outdated
| /** | ||
| * Get the reportID for the associated chatReport | ||
| */ | ||
| function getReportID(route: FlagCommentRouteProp) { |
There was a problem hiding this comment.
Suggested change
| function getReportID(route: FlagCommentRouteProp) { | |
| function getReportID(route: FlagCommentPageNavigationProps['route']) { |
src/pages/FlagCommentPage.tsx
Outdated
| const styles = useThemeStyles(); | ||
| const {translate} = useLocalize(); | ||
|
|
||
| const severities = [ |
src/pages/FlagCommentPage.tsx
Outdated
| }, | ||
| ]; | ||
|
|
||
| const getActionToFlag = useCallback(() => { |
src/pages/FlagCommentPage.tsx
Outdated
|
|
||
| // Handle threads if needed | ||
| if (reportAction?.reportActionID === undefined) { | ||
| reportAction = parentReportActions?.[report?.parentReportActionID ?? ''] ?? undefined; |
There was a problem hiding this comment.
Suggested change
| reportAction = parentReportActions?.[report?.parentReportActionID ?? ''] ?? undefined; | |
| reportAction = parentReportActions?.[report?.parentReportActionID ?? '']; |
src/pages/FlagCommentPage.tsx
Outdated
| return reportAction; | ||
| }, [report, reportActions, route.params.reportActionID, parentReportActions]); | ||
|
|
||
| const flagComment = (severity: ValueOf<typeof CONST.MODERATION>) => { |
There was a problem hiding this comment.
Create a type for ValueOf<typeof CONST.MODERATION>
src/pages/FlagCommentPage.tsx
Outdated
| const flagComment = (severity: ValueOf<typeof CONST.MODERATION>) => { | ||
| let reportID: string | undefined = getReportID(route); | ||
| const reportAction = getActionToFlag(); | ||
| const parentReportAction = parentReportActions?.[report?.parentReportActionID ?? ''] ?? undefined; |
There was a problem hiding this comment.
Suggested change
| const parentReportAction = parentReportActions?.[report?.parentReportActionID ?? ''] ?? undefined; | |
| const parentReportAction = parentReportActions?.[report?.parentReportActionID ?? '']; |
src/pages/FlagCommentPage.tsx
Outdated
Comment on lines
144
to
146
| const actionToFlag = getActionToFlag(); | ||
| const shouldShowFlagComment = actionToFlag && ReportUtils.shouldShowFlagComment(actionToFlag, report); | ||
|
|
There was a problem hiding this comment.
You can get rid of that changes making getActionToFlag return null instead of undefined
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
5da20fc to
fbef230
Compare
Reviewer Checklist
Screenshots/VideosAndroid: Native
Android: mWeb Chrome
iOS: NativeScreen.Recording.2024-02-07.at.01.39.38.moviOS: mWeb Safari
MacOS: Chrome / SafariScreen.Recording.2024-02-07.at.01.28.57.movMacOS: DesktopScreen.Recording.2024-02-07.at.01.32.09.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25184 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
danieldoglas
approved these changes
Feb 8, 2024
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
77 tasks
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
[TS migration] Migrate FlagCommentPage to TypeScript
Fixed Issues
$ #25184
PROPOSAL: N/A
Tests
Test FlagCommentPage:
Offline tests
N/A
QA Steps
Same as in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop