[No QA][Cleanup] Always use constants for screen names

contributingGuides/NAVIGATION.md

@@ -40,7 +40,17 @@ When creating RHP flows, you have to remember a couple things:
 
 An example of adding `Settings_Workspaces` page:
 
-1. Add path to `ROUTES.ts`: https://github.com/Expensify/App/blob/main/src/ROUTES.ts
+1. Add the page name to `SCREENS.ts` which will be reused throughout the app (linkingConfig, navigators, etc.):
+
+```ts
+const SCREENS = {
+    SETTINGS: {
+        WORKSPACES: 'Settings_Workspaces',
+    },
+} as const;
+```
+
+2. Add path to `ROUTES.ts`: https://github.com/Expensify/App/blob/main/src/ROUTES.ts
 
 ```ts
 export const ROUTES = {
@@ -55,11 +65,11 @@ export const ROUTES = {
 
 ```
 
-2. Add `Settings_Workspaces` page to proper RHP flow in `linkingConfig.ts`: https://github.com/Expensify/App/blob/3531af22dcadaa94ed11eccf370517dca0b8c305/src/libs/Navigation/linkingConfig.js#L40-L42
+3. Add `Settings_Workspaces` page to proper RHP flow in `linkingConfig.ts`: https://github.com/Expensify/App/blob/fbc11ca729ffa4676fb3bc8cd110ac3890debff6/src/libs/Navigation/linkingConfig.ts#L47-L50
 
-3. Add your page to proper navigator (it should be aligned with where you've put it in the previous step) https://github.com/Expensify/App/blob/3531af22dcadaa94ed11eccf370517dca0b8c305/src/libs/Navigation/AppNavigator/ModalStackNavigators.js#L334-L338
+4. Add your page to proper navigator (it should be aligned with where you've put it in the previous step) https://github.com/Expensify/App/blob/fbc11ca729ffa4676fb3bc8cd110ac3890debff6/src/libs/Navigation/AppNavigator/ModalStackNavigators.js#L141
 
-4. Make sure `HeaderWithBackButton` leads to the previous page in navigation flow of your page: https://github.com/Expensify/App/blob/3531af22dcadaa94ed11eccf370517dca0b8c305/src/pages/workspace/WorkspacesListPage.js#L186
+5. Make sure `HeaderWithBackButton` leads to the previous page in navigation flow of your page: https://github.com/Expensify/App/blob/3531af22dcadaa94ed11eccf370517dca0b8c305/src/pages/workspace/WorkspacesListPage.js#L186
 
 ## Performance solutions
 

src/SCREENS.ts

@@ -22,6 +22,23 @@ const SCREENS = {
         WORKSPACES: 'Settings_Workspaces',
         SECURITY: 'Settings_Security',
         STATUS: 'Settings_Status',
+        PROFILE: 'Settings_Profile',
+        PRONOUNS: 'Settings_Pronouns',
+        DISPLAY_NAME: 'Settings_Display_Name',
+        TIMEZONE: 'Settings_Timezone',
+        TIMEZONE_SELECT: 'Settings_Timezone_Select',
+        PERSONAL_DETAILS_INITIAL: 'Settings_PersonalDetails_Initial',
+        PERSONAL_DETAILS_LEGAL_NAME: 'Settings_PersonalDetails_LegalName',
+        PERSONAL_DETAILS_DATE_OF_BIRTH: 'Settings_PersonalDetails_DateOfBirth',
+        PERSONAL_DETAILS_ADDRESS: 'Settings_PersonalDetails_Address',
+        PERSONAL_DETAILS_ADDRESS_COUNTRY: 'Settings_PersonalDetails_Address_Country',
+        CONTACT_METHODS: 'Settings_ContactMethods',
+        CONTACT_METHOD_DETAILS: 'Settings_ContactMethodDetails',
+        NEW_CONTACT_METHOD: 'Settings_NewContactMethod',
+        SHARE_CODE: 'Settings_Share_Code',
+        ABOUT: 'Settings_About',
+        APP_DOWNLOAD_LINKS: 'Settings_App_Download_Links',
+        LOUNGE_ACCESS: 'Settings_Lounge_Access',
         WALLET: 'Settings_Wallet',
         WALLET_DOMAIN_CARD: 'Settings_Wallet_DomainCard',
         WALLET_CARD_GET_PHYSICAL: {
@@ -30,14 +47,165 @@ const SCREENS = {
             ADDRESS: 'Settings_Card_Get_Physical_Address',
             CONFIRM: 'Settings_Card_Get_Physical_Confirm',
         },
+        WALLET_TRANSFER_BALANCE: 'Settings_Wallet_Transfer_Balance',
+        WALLET_CHOOSE_TRANSFER_ACCOUNT: 'Settings_Wallet_Choose_Transfer_Account',
+        WALLET_ENABLE_PAYMENTS: 'Settings_Wallet_EnablePayments',
+        WALLET_CARD_ACTIVATE: 'Settings_Wallet_Card_Activate',
+        WALLET_REPORT_VIRTUAL_CARD_FRAUD: 'Settings_Wallet_ReportVirtualCardFraud',
+        WALLET_CARDS_DIGITAL_DETAILS_UPDATE_ADDRESS: 'Settings_Wallet_Cards_Digital_Details_Update_Address',
+        ADD_DEBIT_CARD: 'Settings_Add_Debit_Card',
+        ADD_BANK_ACCOUNT: 'Settings_Add_Bank_Account',
+        PREFERENCES_PRIORITY_MODE: 'Settings_Preferences_PriorityMode',
+        PREFERENCES_LANGUAGE: 'Settings_Preferences_Language',
+        PREFERENCES_THEME: 'Settings_Preferences_Theme',
+        CLOSE: 'Settings_Close',
+        STATUS_SET: 'Settings_Status_Set',
+        TWO_FACTOR_AUTH: 'Settings_TwoFactorAuth',
+        REPORT_CARD_LOST_OR_DAMAGED: 'Settings_ReportCardLostOrDamaged',
     },
     SAVE_THE_WORLD: {
         ROOT: 'SaveTheWorld_Root',
     },
+    RIGHT_MODAL: {
+        SETTINGS: 'Settings',
+        NEW_CHAT: 'NewChat',
+        SEARCH: 'Search',
+        DETAILS: 'Details',
+        PROFILE: 'Profile',
+        REPORT_DETAILS: 'Report_Details',
+        REPORT_SETTINGS: 'Report_Settings',
+        REPORT_WELCOME_MESSAGE: 'Report_WelcomeMessage',
+        PARTICIPANTS: 'Participants',
+        MONEY_REQUEST: 'MoneyRequest',
+        NEW_TASK: 'NewTask',
+        TEACHERS_UNITE: 'TeachersUnite',
+        TASK_DETAILS: 'Task_Details',
+        ENABLE_PAYMENTS: 'EnablePayments',
+        SPLIT_DETAILS: 'SplitDetails',
+        ADD_PERSONAL_BANK_ACCOUNT: 'AddPersonalBankAccount',
+        WALLET_STATEMENT: 'Wallet_Statement',
+        FLAG_COMMENT: 'Flag_Comment',
+        EDIT_REQUEST: 'EditRequest',
+        SIGN_IN: 'SignIn',
+        PRIVATE_NOTES: 'Private_Notes',
+        ROOM_MEMBERS: 'RoomMembers',
+        ROOM_INVITE: 'RoomInvite',
+        REFERRAL: 'Referral',
+    },
     SIGN_IN_WITH_APPLE_DESKTOP: 'AppleSignInDesktop',
     SIGN_IN_WITH_GOOGLE_DESKTOP: 'GoogleSignInDesktop',
     DESKTOP_SIGN_IN_REDIRECT: 'DesktopSignInRedirect',
     SAML_SIGN_IN: 'SAMLSignIn',
+
+    MONEY_REQUEST: {
+        MANUAL_TAB: 'manual',
+        SCAN_TAB: 'scan',
+        DISTANCE_TAB: 'distance',
+        ROOT: 'Money_Request',
+        AMOUNT: 'Money_Request_Amount',
+        PARTICIPANTS: 'Money_Request_Participants',
+        CONFIRMATION: 'Money_Request_Confirmation',
+        CURRENCY: 'Money_Request_Currency',
+        DATE: 'Money_Request_Date',
+        DESCRIPTION: 'Money_Request_Description',
+        CATEGORY: 'Money_Request_Category',
+        TAG: 'Money_Request_Tag',
+        MERCHANT: 'Money_Request_Merchant',
+        WAYPOINT: 'Money_Request_Waypoint',
+        EDIT_WAYPOINT: 'Money_Request_Edit_Waypoint',
+        DISTANCE: 'Money_Request_Distance',
+        RECEIPT: 'Money_Request_Receipt',
+    },
+
+    IOU_SEND: {
+        ADD_BANK_ACCOUNT: 'IOU_Send_Add_Bank_Account',
+        ADD_DEBIT_CARD: 'IOU_Send_Add_Debit_Card',
+        ENABLE_PAYMENTS: 'IOU_Send_Enable_Payments',
+    },
+
+    REPORT_SETTINGS: {
+        ROOT: 'Report_Settings_Root',
+        ROOM_NAME: 'Report_Settings_Room_Name',
+        NOTIFICATION_PREFERENCES: 'Report_Settings_Notification_Preferences',
+        WRITE_CAPABILITY: 'Report_Settings_Write_Capability',
+    },
+
+    NEW_TASK: {
+        ROOT: 'NewTask_Root',
+        TASK_ASSIGNEE_SELECTOR: 'NewTask_TaskAssigneeSelector',
+        TASK_SHARE_DESTINATION_SELECTOR: 'NewTask_TaskShareDestinationSelector',
+        DETAILS: 'NewTask_Details',
+        TITLE: 'NewTask_Title',
+        DESCRIPTION: 'NewTask_Description',
+    },
+
+    TASK: {
+        TITLE: 'Task_Title',
+        DESCRIPTION: 'Task_Description',
+        ASSIGNEE: 'Task_Assignee',
+    },
+
+    PRIVATE_NOTES: {
+        VIEW: 'PrivateNotes_View',
+        LIST: 'PrivateNotes_List',
+        EDIT: 'PrivateNotes_Edit',
+    },
+
+    REPORT_DETAILS: {
+        ROOT: 'Report_Details_Root',
+        SHARE_CODE: 'Report_Details_Share_Code',
+    },
+
+    WORKSPACE: {
+        INITIAL: 'Workspace_Initial',
+        SETTINGS: 'Workspace_Settings',
+        CARD: 'Workspace_Card',
+        REIMBURSE: 'Workspace_Reimburse',
+        RATE_AND_UNIT: 'Workspace_RateAndUnit',
+        BILLS: 'Workspace_Bills',
+        INVOICES: 'Workspace_Invoices',
+        TRAVEL: 'Workspace_Travel',
+        MEMBERS: 'Workspace_Members',
+        INVITE: 'Workspace_Invite',
+        INVITE_MESSAGE: 'Workspace_Invite_Message',
+        CURRENCY: 'Workspace_Settings_Currency',
+    },
+
+    EDIT_REQUEST: {
+        ROOT: 'EditRequest_Root',
+        CURRENCY: 'EditRequest_Currency',
+    },
+
+    I_KNOW_A_TEACHER: 'I_Know_A_Teacher',
+    INTRO_SCHOOL_PRINCIPAL: 'Intro_School_Principal',
+    I_AM_A_TEACHER: 'I_Am_A_Teacher',
+
+    ENABLE_PAYMENTS_ROOT: 'EnablePayments_Root',
+    ADD_PERSONAL_BANK_ACCOUNT_ROOT: 'AddPersonalBankAccount_Root',
+    REIMBURSEMENT_ACCOUNT_ROOT: 'Reimbursement_Account_Root',
+    WALLET_STATEMENT_ROOT: 'WalletStatement_Root',
+    SIGN_IN_ROOT: 'SignIn_Root',
+    REFERRAL_DETAILS: 'Referral_Details',
+
+    SPLIT_DETAILS: {
+        ROOT: 'SplitDetails_Root',
+        EDIT_REQUEST: 'SplitDetails_Edit_Request',
+        EDIT_CURRENCY: 'SplitDetails_Edit_Currency',
+    },
+
+    DETAILS_ROOT: 'Details_Root',
+    PROFILE_ROOT: 'Profile_Root',
+    REPORT_WELCOME_MESSAGE_ROOT: 'Report_WelcomeMessage_Root',
+    REPORT_PARTICIPANTS_ROOT: 'ReportParticipants_Root',
+    ROOM_MEMBERS_ROOT: 'RoomMembers_Root',
+    ROOM_INVITE_ROOT: 'RoomInvite_Root',
+    SEARCH_ROOT: 'Search_Root',
+    NEW_CHAT: {ROOT: 'NewChat_Root', NEW_CHAT: 'chat', NEW_ROOM: 'room'},
+    FLAG_COMMENT_ROOT: 'FlagComment_Root',
+    REIMBURSEMENT_ACCOUNT: 'ReimbursementAccount',
+    GET_ASSISTANCE: 'GetAssistance',
+
+    KEYBOARD_SHORTCUTS: 'KeyboardShortcuts',
 } as const;
 
 export default SCREENS;