Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task title escaping #32364

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Fix task title escaping #32364

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bdbfb2a
escape task title
FitseTLT Nov 30, 2023
a7460f7
updated getLastMessageTextForReport to return lastMessageHtml for tas…
FitseTLT Nov 30, 2023
613b6f7
added comment
FitseTLT Dec 1, 2023
048130c
Merge branch 'main' into fix-task-title-escaping
FitseTLT Dec 1, 2023
15a6bf7
removed unnecessary fix
FitseTLT Dec 5, 2023
260b768
removed unnecessary code
FitseTLT Dec 5, 2023
2a890e2
Merge branch 'main' into fix-task-title-escaping
FitseTLT Dec 9, 2023
938ea3e
resolved conflict
FitseTLT Dec 9, 2023
bc2070c
removed unnecessary newlines
FitseTLT Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ReportActionItem/TaskPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function TaskPreview(props) {
const isTaskCompleted = !_.isEmpty(props.taskReport)
? props.taskReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.taskReport.statusNum === CONST.REPORT.STATUS.APPROVED
: props.action.childStateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.action.childStatusNum === CONST.REPORT.STATUS.APPROVED;
const taskTitle = TaskUtils.getTaskTitle(props.taskReportID, props.action.childReportName);
const taskTitle = _.escape(TaskUtils.getTaskTitle(props.taskReportID, props.action.childReportName));
const taskAssigneeAccountID = Task.getTaskAssigneeAccountID(props.taskReport) || props.action.childManagerAccountID;
const assigneeLogin = lodashGet(personalDetails, [taskAssigneeAccountID, 'login'], '');
const assigneeDisplayName = lodashGet(personalDetails, [taskAssigneeAccountID, 'displayName'], '');
Expand Down