Fix:30734 - tag esc character issue #31494

FitseTLT · 2023-11-17T17:26:12Z

Details

Fixed Issues

$ #30734
PROPOSAL: #30734 (comment)

Tests

First create hierarchial tags in the form of "Parent: Child" in old dot.
2.. Go to workspace chat > + > Request money > Manual.
Enter the amount and proceed to confirmation page.
Click Tag and verify that the "Parent: Child" tags you have created in (1) appear as "Parent: Child" not "Parent\: Child".
Select a "Parent: Child" tag verify that tag appear as "Parent: Child" not "Parent\: Child" in the confirmation page.
View the detail page for the request and check the tag appears as "Parent: Child" not "Parent\: Child".
Change it to other "Parent:child" tag and verify the tag appears as "Parent: Child" not "Parent\: Child".

Verify that no errors appear in the JS console

Offline tests

First create hierarchial tags in the form of "Parent: Child" in old dot.
2.. Go to workspace chat > + > Request money > Manual.
Enter the amount and proceed to confirmation page.
Click Tag and verify that the "Parent: Child" tags you have created in (1) appear as "Parent: Child" not "Parent\: Child".
Select a "Parent: Child" tag verify that tag appear as "Parent: Child" not "Parent\: Child" in the confirmation page.
View the detail page for the request and check the tag appears as "Parent: Child" not "Parent\: Child".
Change it to other "Parent:child" tag and verify the tag appears as "Parent: Child" not "Parent\: Child".

QA Steps

First create hierarchial tags in the form of "Parent: Child" in old dot.
2.. Go to workspace chat > + > Request money > Manual.
Enter the amount and proceed to confirmation page.
Click Tag and verify that the "Parent: Child" tags you have created in (1) appear as "Parent: Child" not "Parent\: Child".
Select a "Parent: Child" tag verify that tag appear as "Parent: Child" not "Parent\: Child" in the confirmation page.
View the detail page for the request and check the tag appears as "Parent: Child" not "Parent\: Child".
Change it to other "Parent:child" tag and verify the tag appears as "Parent: Child" not "Parent\: Child".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.native.mp4

Android: mWeb Chrome

Android.mWeb.mp4

iOS: Native

IOS.Native.mp4

iOS: mWeb Safari

IOS.mWeb.mp4

MacOS: Chrome / Safari

Web.2.mp4

MacOS: Desktop

Desktop.mp4

melvin-bot · 2023-11-17T17:26:18Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-11-17T17:26:27Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

FitseTLT · 2023-11-17T17:39:49Z

I have read the CLA Document and I hereby sign the CLA

FitseTLT · 2023-11-17T17:46:14Z

recheck

jjcoffee · 2023-11-20T13:25:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2023-11-20_14.49.02.mp4

Android: mWeb Chrome

android-chrome-2023-11-20_14.44.19.mp4

iOS: Native

ios-native-2023-11-20_14.40.05.mp4

iOS: mWeb Safari

ios-safari-2023-11-20_14.38.55.mp4

MacOS: Chrome / Safari

desktop-chrome-2023-11-20_14.29.58.mp4

MacOS: Desktop

desktop-app-2023-11-20_15.10.51.mp4

jjcoffee · 2023-11-20T13:27:14Z

@FitseTLT In your test steps the backslashes are missing ("Parent: Child" not "Parent: Child"), if you wrap them in a code block they should display.

FitseTLT · 2023-11-20T13:33:26Z

@FitseTLT In your test steps the backslashes are missing ("Parent: Child" not "Parent: Child"), if you wrap them in a code block they should display.

Thanks @jjcoffee Updated 👍

jjcoffee · 2023-11-20T14:26:35Z

Tests well, but there's a little edge case if we ever (for some reason!) wanted a backslash in the tag name itself. I reckon we could just limit the regex to only replace \:?

FitseTLT · 2023-11-20T14:35:49Z

Tests well, but there's a little edge case if we ever (for some reason!) wanted a backslash in the tag name itself. I reckon we could just limit the regex to only replace \:?

Ok. But should I still consider multiple (double) backslashes as this comment or only one slash??

jjcoffee · 2023-11-20T14:55:40Z

@FitseTLT Yes the name that we get from the BE is double backslashed so I'd say we need to handle either one or two (unsure if it'll ever be 1 but it's probably worth supporting in case BE gets fixed to stop double-escaping 😉).

FitseTLT · 2023-11-20T15:11:22Z

Updated as per your suggestion. But for your info tag.name is not having double backslashes, having only one slash. For this specific issue there is no reason to include double slashes but I 've included it.

jjcoffee · 2023-11-20T15:13:19Z

Hmm I see them in Onyx, maybe they're escaped when we pull from there?

jjcoffee

LGTM!

roryabraham · 2023-11-21T00:02:29Z

Typecheck failure is a false negative, created issue and fix. Not going to block this PR on the false negative

melvin-bot · 2023-11-21T00:02:44Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

roryabraham · 2023-11-21T00:02:57Z

Not an emergency, see last comment

OSBotify · 2023-11-21T00:06:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-22T01:03:39Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-23T16:55:11Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

FitseTLT added 2 commits November 15, 2023 20:38

added code to remove escaping backslash from tag

ee49bf6

added null checker

200aa25

FitseTLT requested a review from a team as a code owner November 17, 2023 17:26

melvin-bot bot requested review from jjcoffee and removed request for a team November 17, 2023 17:26

removed optional chaining

ebfbc79

updated to remove esc only if it is before colon

7de5d9f

jjcoffee approved these changes Nov 20, 2023

View reviewed changes

melvin-bot bot requested a review from roryabraham November 20, 2023 15:35

roryabraham approved these changes Nov 20, 2023

View reviewed changes

This was referenced Nov 20, 2023

[HOLD for payment 2023-12-04] False negative on typecheck PR check #31598

Closed

[No QA] Cross-check the files touched by a PR in typecheck #31599

Merged

roryabraham merged commit 5a59bdb into Expensify:main Nov 21, 2023

melvin-bot bot added the Emergency label Nov 21, 2023

roryabraham removed the Emergency label Nov 21, 2023

github-actions bot mentioned this pull request Nov 22, 2023

Deploy Checklist: New Expensify 2023-11-22 #31667

Closed

62 tasks

lanitochka17 mentioned this pull request Nov 22, 2023

[$500] Tag - Child tags are not indented on list #31753

Closed

6 tasks

bondydaa mentioned this pull request Nov 22, 2023

[HOLD for payment 2023-12-07] Tag - Child tags are not displayed in Recent #31760

Closed

6 tasks

melvin-bot bot mentioned this pull request Nov 23, 2023

[$500] [Wave 6: Tags] Tag written as "Parents: Child" appears as "Parents\: Child" #30734

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix:30734 - tag esc character issue #31494

Fix:30734 - tag esc character issue #31494

FitseTLT commented Nov 17, 2023 •

edited

Loading

melvin-bot bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023 •

edited

Loading

FitseTLT commented Nov 17, 2023 •

edited

Loading

FitseTLT commented Nov 17, 2023

jjcoffee commented Nov 20, 2023 •

edited

Loading

jjcoffee commented Nov 20, 2023

FitseTLT commented Nov 20, 2023

jjcoffee commented Nov 20, 2023

FitseTLT commented Nov 20, 2023

jjcoffee commented Nov 20, 2023

FitseTLT commented Nov 20, 2023

jjcoffee commented Nov 20, 2023

jjcoffee left a comment

roryabraham commented Nov 21, 2023

melvin-bot bot commented Nov 21, 2023

roryabraham commented Nov 21, 2023

OSBotify commented Nov 21, 2023

OSBotify commented Nov 22, 2023

OSBotify commented Nov 23, 2023

Fix:30734 - tag esc character issue #31494

Fix:30734 - tag esc character issue #31494

Conversation

FitseTLT commented Nov 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023 • edited Loading

FitseTLT commented Nov 17, 2023 • edited Loading

FitseTLT commented Nov 17, 2023

jjcoffee commented Nov 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Nov 20, 2023

FitseTLT commented Nov 20, 2023

jjcoffee commented Nov 20, 2023

FitseTLT commented Nov 20, 2023

jjcoffee commented Nov 20, 2023

FitseTLT commented Nov 20, 2023

jjcoffee commented Nov 20, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

roryabraham commented Nov 21, 2023

melvin-bot bot commented Nov 21, 2023

roryabraham commented Nov 21, 2023

OSBotify commented Nov 21, 2023

OSBotify commented Nov 22, 2023

OSBotify commented Nov 23, 2023

FitseTLT commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

FitseTLT commented Nov 17, 2023 •

edited

Loading

jjcoffee commented Nov 20, 2023 •

edited

Loading