Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: using SET method to save updated transaction #31340

Merged
merged 2 commits into from
Nov 30, 2023
+2 −1
Merged

Fix: using SET method to save updated transaction #31340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72113b4
using SET to save updated transaction
DylanDylann Nov 15, 2023
88ebfd8
add comment
DylanDylann Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libs/actions/IOU.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,8 @@ function updateDistanceRequest(transactionID, transactionThreadReportID, transac

// Optimistically modify the transaction
optimisticData.push({
onyxMethod: Onyx.METHOD.MERGE,
// We need to use SET method to save updated waypoint instead MERGE method to avoid wrong update of waypoints. More detail: https://github.com/Expensify/App/issues/30290#issuecomment-1778957070
onyxMethod: Onyx.METHOD.SET,
key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
value: {
...updatedTransaction,
Expand Down