Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Empty transaction data on log in #31302

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Fix: Empty transaction data on log in #31302

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
33b048d
fix: empty transaction data on open app
tienifr Nov 14, 2023
bbe5c52
get message from parent report action
tienifr Nov 14, 2023
7c2efa5
Merge branch 'main' of https://github.com/tienifr/App into fix/30687
tienifr Nov 21, 2023
44179cc
Merge branch 'main' of https://github.com/tienifr/App into fix/30687
tienifr Nov 22, 2023
4deb7a4
add comment
tienifr Nov 22, 2023
e9ab87d
Merge branch 'main' into fix/30687
tienifr Nov 27, 2023
6478fc5
fix typescript lint
tienifr Nov 27, 2023
57b3f6b
Merge branch 'main' of https://github.com/tienifr/App into fix/30687
tienifr Nov 28, 2023
e9fa9ff
Fallback to Request for empty transaction
tienifr Nov 28, 2023
63c40d5
Merge branch 'fix/30687' of https://github.com/tienifr/App into fix/3…
tienifr Nov 28, 2023
ad6fb76
modify comment
tienifr Nov 28, 2023
fb5e067
Merge branch 'main' of https://github.com/tienifr/App into fix/30687
tienifr Nov 29, 2023
9a1a91f
Merge branch 'main' of https://github.com/tienifr/App into fix/30687
tienifr Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libs/ReportUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,6 +1769,9 @@ function getTransactionReportName(reportAction) {
}

const transaction = TransactionUtils.getLinkedTransaction(reportAction);
if (_.isEmpty(transaction)) {
return lodashGet(reportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment to the code.

if (TransactionUtils.hasReceipt(transaction) && TransactionUtils.isReceiptBeingScanned(transaction)) {
return Localize.translateLocal('iou.receiptScanning');
}
Expand Down Expand Up @@ -2078,6 +2081,9 @@ function getReportName(report, policy = undefined) {
const parentReportAction = ReportActionsUtils.getParentReportAction(report);
if (isChatThread(report)) {
if (ReportActionsUtils.isTransactionThread(parentReportAction)) {
if (_.isEmpty(parentReportAction)) {
return Localize.translateLocal('iou.request');
}
return getTransactionReportName(parentReportAction);
}

Expand Down