Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Composer is not focused when press Message User in Profile page #30973

Merged
merged 15 commits into from
Dec 1, 2023
+3 −2
Merged

Fix: Composer is not focused when press Message User in Profile page #30973

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9a6375a
fix: 30254
tienifr Oct 28, 2023
6d09d59
Merge branch 'main' of https://github.com/tienifr/App into fix/30254
tienifr Nov 7, 2023
331e2a8
fix lint
tienifr Nov 7, 2023
2b7be0a
refactor code
tienifr Nov 7, 2023
4294da8
fix lint
tienifr Nov 7, 2023
f3c06d6
Merge branch 'main' of https://github.com/tienifr/App into fix/30254
tienifr Nov 8, 2023
5464fc5
remove clearTimeout
tienifr Nov 8, 2023
417b519
Merge branch 'main' of https://github.com/tienifr/App into fix/30254
tienifr Nov 15, 2023
816a67c
refactor to handle focus in the same useEffect
tienifr Nov 15, 2023
f671ed3
fix lint
tienifr Nov 15, 2023
e8c5d79
Merge branch 'main' of https://github.com/tienifr/App into fix/30254
tienifr Nov 22, 2023
4a8be24
Merge branch 'main' into fix/30254
tienifr Nov 27, 2023
ac9c935
add shouldAutoFocus to dependencies
tienifr Nov 27, 2023
d58d465
Merge branch 'main' of https://github.com/tienifr/App into fix/30254
tienifr Nov 28, 2023
a08dadd
remove log
tienifr Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,7 @@ function ComposerWithSuggestions({
const prevIsModalVisible = usePrevious(modal.isVisible);
const prevIsFocused = usePrevious(isFocused);
useEffect(() => {
console.log('abcdef');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it accidentally added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! Removed!

if (modal.isVisible && !prevIsModalVisible) {
// eslint-disable-next-line no-param-reassign
isNextModalWillOpenRef.current = false;
Expand All @@ -507,8 +508,7 @@ function ComposerWithSuggestions({
return;
}
focus(true);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [focus, prevIsFocused, editFocused, prevIsModalVisible, isFocused, modal.isVisible, isNextModalWillOpenRef]);
}, [focus, prevIsFocused, editFocused, prevIsModalVisible, isFocused, modal.isVisible, isNextModalWillOpenRef, shouldAutoFocus]);

useEffect(() => {
// Scrolls the composer to the bottom and sets the selection to the end, so that longer drafts are easier to edit
Expand Down