Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go back from flag comment page to report #30289

Merged
merged 13 commits into from
Nov 28, 2023
+20 −7
Merged

fix go back from flag comment page to report #30289

Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
174679d
fix go back from flag comment page to report
suneox Oct 24, 2023
2f925fb
only update for browser mobile
suneox Oct 26, 2023
0ea8d0d
update navigation back to navigate
suneox Oct 26, 2023
2db535b
fix code lint
suneox Oct 26, 2023
e61f16f
handle go back by topMostReportID
suneox Oct 26, 2023
2953212
Merge branch 'main' into fix/30101-go-back-from-flag-as-offensive-page
suneox Nov 11, 2023
d776642
run prettier
suneox Nov 11, 2023
c60ccfc
Merge branch 'main' into fix/30101-go-back-from-flag-as-offensive-page
suneox Nov 12, 2023
e1ae94c
Merge branch 'main' into fix/30101-go-back-from-flag-as-offensive-page
suneox Nov 14, 2023
8f4a229
Merge remote-tracking branch 'upstream/main' into fix/30101-go-back-f…
suneox Nov 16, 2023
ea1e8e2
Merge remote-tracking branch 'upstream/main' into fix/30101-go-back-f…
suneox Nov 19, 2023
0f164c7
move condition check topMostReportID to HeaderWithBackButton
suneox Nov 20, 2023
e43e3db
rename props
suneox Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/pages/FlagCommentPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import * as Report from '@userActions/Report';
import * as Session from '@userActions/Session';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import reportActionPropTypes from './home/report/reportActionPropTypes';
import withReportAndReportActionOrNotFound from './home/report/withReportAndReportActionOrNotFound';
import reportPropTypes from './reportPropTypes';
Expand Down Expand Up @@ -161,7 +162,18 @@ function FlagCommentPage(props) {
>
{({safeAreaPaddingBottomStyle}) => (
<FullPageNotFoundView shouldShow={!ReportUtils.shouldShowFlagComment(getActionToFlag(), props.report)}>
<HeaderWithBackButton title={props.translate('reportActionContextMenu.flagAsOffensive')} />
<HeaderWithBackButton
title={props.translate('reportActionContextMenu.flagAsOffensive')}
onBackButtonPress={() => {
const topMostReportID = Navigation.getTopmostReportId();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suneox I can see this is exactly same as ReportDetailsPage. Why not move this to a util? so that we can use it again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add props link shouldAwareTopMostReport default is false into HeaderWithBackButton and move logic

        const topMostReportID = Navigation.getTopmostReportId();
        if (topMostReportID) {
            Navigation.goBack(ROUTES.HOME);
            return;
        }

before onBackButtonPress callback
Change current to

      <PressableWithoutFeedback
        onPress={() => {
            if (isKeyboardShown) {
                Keyboard.dismiss();
            }
            const topMostReportID = Navigation.getTopmostReportId();
            if (shouldAwareTopMostReport && topMostReportID) {
                Navigation.goBack(ROUTES.HOME);
            } else {
                onBackButtonPress();
            }
        }}

Then add props shouldAwareTopMostReport to ReportDetailsPage and FlagCommentPage
@mananjadhav What do you think about this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we modify the condition so that topMostReportID is fetched only if shouldAwareTopMostReport is set true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes so the condition look like this if (shouldAwareTopMostReport && Navigation.getTopmostReportId())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the condition and synced it with the latest main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mananjadhav i have updated condition before get topMostReportID

if (topMostReportID) {
Navigation.goBack(ROUTES.HOME);
return;
}
Navigation.goBack();
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID));
}}
/>
<ScrollView
contentContainerStyle={safeAreaPaddingBottomStyle}
style={styles.settingsPageBackground}
Expand Down