Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reportIDList param when getting the reports for a new IOU transaction #3018

Merged
merged 1 commit into from
May 20, 2021

Conversation

francoisl
Copy link
Contributor

@francoisl francoisl commented May 19, 2021

Details

In getIOUReportsForNewTransaction, we need pass a CSV list of the report IDs we want to retrieve from the API. _.pluck() returns an array, so we need to join it with commas.

Fixed Issues

Fixes #2995

Tests / QA

  1. On the home screen, press the + icon
  2. Press "Request Money"
  3. Enter an amount in the modal.
  4. Hit Next
  5. Select any user
  6. Click the "Request Money" button
  7. Make sure that you're redirected back to the home screen, and the green IOU amount pill is displayed with the updated amount

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-05-19 at 1 49 26 PM

Screen Shot 2021-05-19 at 1 49 50 PM

iOS

Screen Shot 2021-05-19 at 2 19 24 PM

Screen Shot 2021-05-19 at 2 19 42 PM

Android

image
image

@github-actions

This comment has been minimized.

@francoisl

This comment has been minimized.

@francoisl francoisl marked this pull request as ready for review May 19, 2021 21:31
@francoisl francoisl requested a review from a team as a code owner May 19, 2021 21:31
@francoisl francoisl self-assigned this May 19, 2021
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team May 19, 2021 21:31
@ctkochan22 ctkochan22 merged commit a006c9e into main May 20, 2021
@ctkochan22 ctkochan22 deleted the francoisFixIOUReportIDList branch May 20, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOU - Android - Nothing happened after clicked Request Money button
2 participants