Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Remove unused methods and exports #3016

Merged
merged 3 commits into from
May 19, 2021
Merged

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented May 19, 2021

This is just some cleanup that I came across

Tests / QA Steps

No QA - Normal regression steps will catch anything

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@tgolen tgolen requested a review from a team May 19, 2021 19:27
@tgolen tgolen self-assigned this May 19, 2021
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team May 19, 2021 19:27
@tgolen tgolen requested a review from a team as a code owner May 19, 2021 20:23
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team May 19, 2021 20:23
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing b/c of an unused import

@@ -119,7 +119,6 @@ class AuthScreens extends React.Component {
User.getBetas();
fetchAllReports(true, true);
fetchCountryCodeByRequestIP();
BankAccounts.fetchBankAccountList();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the BankAccounts import at the top of the file can also be removed

pecanoro
pecanoro previously approved these changes May 19, 2021
@tgolen
Copy link
Contributor Author

tgolen commented May 19, 2021 via email

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit ff61c1a into main May 19, 2021
@Jag96 Jag96 deleted the tgolen-cleanup-exports branch May 19, 2021 23:34
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants