Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the icon used for notifications #3013

Merged
merged 2 commits into from
May 19, 2021
Merged

Update the icon used for notifications #3013

merged 2 commits into from
May 19, 2021

Conversation

shawnborton
Copy link
Contributor

Details

This updates the notification badge icon to use our iconmark with a white background. cc @puneetlath

Fixed Issues

N/A

Tests/QA Steps

  1. Receive a message using the desktop app and check to see that the notification image has been updated

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

N/A

Mobile Web

N/A

Desktop

image

iOS

N/A

Android

N/A

@shawnborton shawnborton requested a review from a team May 19, 2021 17:28
@shawnborton shawnborton self-assigned this May 19, 2021
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team May 19, 2021 17:29
@shawnborton shawnborton requested a review from a team as a code owner May 19, 2021 17:29
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team May 19, 2021 17:29
@ctkochan22 ctkochan22 merged commit 85b084c into main May 19, 2021
@ctkochan22 ctkochan22 deleted the shawn-notification branch May 19, 2021 19:47
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants