Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mail icon #2994

Merged
merged 2 commits into from
May 19, 2021
Merged

Change mail icon #2994

merged 2 commits into from
May 19, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented May 19, 2021

Details

Updates the mail icon.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/164436

Tests / QA Steps (web/desktop)

  1. Hover over a chat.
  2. Verify that the ReportActionContextMenu that appears displays a closed envelope icon instead of an open one.
  3. Hover over the closed envelope icon, and verify that the Tooltip says 'Mark as Unread'
  4. Right-click on a chat.
  5. Verify that the Mark as Unread menu item displays a closed envelope icon.

Tests / QA Steps (iOS/Android/mWeb)

  1. Long-press a chat.
  2. Verify that the Mark as Unread menu item displays a closed envelope icon.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

image

Mobile Web

(ignore the highlight bugs that are present on main)

image

Desktop

image

image

iOS

image

Android

@roryabraham roryabraham requested a review from shawnborton May 19, 2021 00:33
@roryabraham roryabraham requested a review from a team as a code owner May 19, 2021 00:33
@roryabraham roryabraham self-assigned this May 19, 2021
@MelvinBot MelvinBot requested review from deetergp and removed request for a team May 19, 2021 00:33
@roryabraham roryabraham changed the title Rory change mail icon Change mail icon May 19, 2021
@roryabraham
Copy link
Contributor Author

@deetergp I'm going to merge this. I just changed an image asset so there's not much to review here.

@roryabraham roryabraham merged commit 5283392 into main May 19, 2021
@roryabraham roryabraham deleted the Rory-ChangeMailIcon branch May 19, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants