Disable documentTitle in NavigationRoot component #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
reviewed
May 19, 2021
|
Updated. |
marcaaron
approved these changes
May 19, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mu
Details
The listener that sets the page title when there are new chat items, that gets attached in
AuthScreenswas getting overridden by theNavigationContainerin NavigationRoot.js, which apparently mounts a few more times after the listener updates the title. This changes it so that theNavigationContaineronly sets the title toExpnesify.cashwhen thedocument.titleis not already set.cc @marcaaron
Fixed Issues
Fixes #2636
Tests/QA
(NEW!) Expensify.cashis set, it stays set.Tested On
Screenshots
Web
flasherFix.mp4