Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Onyx version to fix resetting default values #2979

Merged
merged 4 commits into from
May 21, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented May 18, 2021

Details

cc @Julesssss

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/164467

Tests

  1. Log into E.cash
  2. Wait for all network requests to finish
  3. Log out
  4. Verify the following default keys can be seen in storage
{
    session: {loading: false, shouldShowComposeInput: true},
    account: {error: "", success: "", loading: false}
    network: {isOffline: false},
    iou: {loading: false},
}

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this May 18, 2021
@marcaaron marcaaron changed the title Bump Onyx version to fix resetting default values [HOLD] Bump Onyx version to fix resetting default values May 18, 2021
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, but would you mind merging main so that we can include the new IOU keys introduced by IOU Details Modal. Thanks!

@marcaaron marcaaron marked this pull request as ready for review May 20, 2021 18:15
@marcaaron marcaaron requested a review from a team as a code owner May 20, 2021 18:15
@marcaaron marcaaron changed the title [HOLD] Bump Onyx version to fix resetting default values Bump Onyx version to fix resetting default values May 20, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team May 20, 2021 18:15
@marcaaron
Copy link
Contributor Author

Updated

@marcaaron marcaaron requested a review from Julesssss May 20, 2021 18:19
Julesssss
Julesssss previously approved these changes May 21, 2021
@Julesssss
Copy link
Contributor

Confirmed that the original IOU error is fixed, give us a bump when the conflict is resolved 👍

MonilBhavsar
MonilBhavsar previously approved these changes May 21, 2021
@MonilBhavsar
Copy link
Contributor

Tested, works well!

@marcaaron marcaaron dismissed stale reviews from MonilBhavsar and Julesssss via 77f03e7 May 21, 2021 16:35
@marcaaron
Copy link
Contributor Author

Updated

@Julesssss
Copy link
Contributor

@marcaaron I'm heading out soon, but feel free to merge when the iOS tests complete

@marcaaron marcaaron merged commit c788e48 into main May 21, 2021
@marcaaron marcaaron deleted the marcaaron-updateOnyxToInitWithValuesOnClear branch May 21, 2021 17:15
@isagoico
Copy link

@marcaaron Any QA steps for this one?

@marcaaron
Copy link
Contributor Author

Ah woops sorry. None besides testing logging in and out and verifying that the data looks correct in the localStorage

I tested on staging and everything looks OK to me.

Screen Shot 2021-05-21 at 8 07 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants