[No QA] Apply engineering label to deploy blockers, not demolition #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwiznia
previously approved these changes
May 17, 2021
rafecolton
previously approved these changes
May 17, 2021
|
Sorry, I added another quick fix in this PR to fix this failed workflow run |
26 tasks
rafecolton
approved these changes
May 17, 2021
|
Okay, going to merge this and test it out |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Okay, this worked! I'm going to adjust the Slack comment so it doesn't ping everyone in the channel for a deploy blocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Coming from this (long) thread.
Fixed Issues
n/a
Tests
DeployBlockerCash.Hourly,Engineering.QA Steps
None.
Tested On
Live-testing only 🤪