-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IOU routes to Universal Links (AASA) #2970
Conversation
I couldn't find a way to test this locally from the dev environment I created a local server where I hosted the AASA file and an html file with a link like https://staging.expensify.cash/iou/split but since my local server is not registered in associated domains here it does not work I can't add my test server to Associated Domains to see if things work in dev, because in order to build I'd have to update the signing configuration, with my development account and then use a different bundle ID and then add this ID in AASA ... I saw Storybook was recently added to the app, and I've allowed myself the liberty to place a "story" that allows you to manually test deep links (and Universal Links) Deep.Links.mp4Of course if this doesn't look useful to you it's just my last commit and I can easily drop it Whatever you decide, updating the staging environment (and prod) with the new AASA file should resolve the issue One thing I noticed that the provided link in the ticket is missing a reportID parameter - https://staging.expensify.cash/iou/split Here's a sample video with the link including and not including a report ID Screen.Recording.2021-05-18.at.0.13.32.mov |
cdb6421
to
9aa1590
Compare
Hey @marcaaron, requesting your review here since I'm not very familiar with IOUs in general |
Hi @kidroca! Thanks! |
9aa1590
to
4965091
Compare
Thanks, I've extracted it to a separate branch here: kidroca@17a3800 Will post a ticket about it when I get some free time |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Details
Updated the AASA (apple-app-site-association) file with configuration for the IOU routes
Fixed Issues
Fixes #2401
Tests
QA Steps
Same as above
Tested On
I've tested primarily on iOS.
Since I can't test this change locally, I've just verified the other platforms are still working
Screenshots
Web
Mobile Web
Desktop
iOS
The changes that I used to test this locally were reverted.
Deep.Links.mp4
Android