Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Emoji Picker Styles #2955

Merged
merged 2 commits into from
May 18, 2021
Merged

fix: Emoji Picker Styles #2955

merged 2 commits into from
May 18, 2021

Conversation

parasharrajat
Copy link
Member

Details

  1. Set the Fixed width on Emoji Picker for Web & 100% for Mobile web.

Fixed Issues

Fixes #2446

Tests \ QA Steps

  1. Log in to expensify cash
  2. Go to a conversation and click on the emoji icon
  3. Search for an emoji.
  4. Emoji picker box's size should not change.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

emoji-web.mp4

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner May 16, 2021 19:43
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team May 16, 2021 19:43
@parasharrajat
Copy link
Member Author

Ready for review.

nickmurray47
nickmurray47 approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tests well

@nickmurray47 nickmurray47 merged commit b02dbec into Expensify:main May 18, 2021
@OSBotify OSBotify mentioned this pull request May 18, 2021
Closed
26 tasks
@parasharrajat parasharrajat deleted the emojiPicker branch November 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmurray47 nickmurray47 nickmurray47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emoji picker - Box changes size when you search for an emoji on Windows Chrome
2 participants
@parasharrajat @nickmurray47