Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Don't Overwrite Storybook docs directory when deploying #2949

Merged
merged 4 commits into from
May 15, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented May 15, 2021

Details

This should work 🤞

Fixed Issues

No Issue. But follow up to https://github.com/Expensify/Expensify/issues/164021

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@botify
Copy link

botify commented May 15, 2021

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@marcaaron marcaaron self-assigned this May 15, 2021
@marcaaron marcaaron changed the title Build docs them move [No QA] Don't Overwrite Storybook docs directory when deploying May 15, 2021
@botify
Copy link

botify commented May 15, 2021

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@marcaaron marcaaron requested a review from roryabraham May 15, 2021 00:04
@botify
Copy link

botify commented May 15, 2021

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@marcaaron marcaaron marked this pull request as ready for review May 15, 2021 00:22
@marcaaron marcaaron requested a review from a team as a code owner May 15, 2021 00:22
@marcaaron marcaaron removed the request for review from a team May 15, 2021 00:22
@MelvinBot MelvinBot requested a review from joelbettner May 15, 2021 00:23
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a go!

@marcaaron marcaaron removed the request for review from joelbettner May 15, 2021 00:25
@roryabraham roryabraham merged commit 8bb7d67 into main May 15, 2021
@roryabraham roryabraham deleted the marcaaron-buildDocs branch May 15, 2021 00:25
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.46-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants