-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Don't Overwrite Storybook docs directory when deploying #2949
Conversation
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
npm has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a go!
🚀 Deployed to staging in version: 1.0.46-2🚀
|
Details
This should work 🤞
Fixed Issues
No Issue. But follow up to https://github.com/Expensify/Expensify/issues/164021
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android