[No QA] Fix all propTypes to use block comments #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikkiWines
requested changes
May 14, 2021
| onLinkClick: PropTypes.func.isRequired, | ||
|
|
||
| // navigates to settings and hides sidebar | ||
| /** navigates to settings and hides sidebar */ |
There was a problem hiding this comment.
NAB: should be capitalized
| onConfirm: PropTypes.func.isRequired, | ||
|
|
||
| // callback to update comment from IOUModal | ||
| /** callback to update comment from IOUModal */ |
There was a problem hiding this comment.
NAB: should be capitalized
| pronouns: PropTypes.string, | ||
|
|
||
| // timezone of the current user from their personal details | ||
| /** timezone of the current user from their personal details */ |
There was a problem hiding this comment.
NAB: should be capitalized
src/pages/signin/SignInPage.js
Outdated
| error: PropTypes.string, | ||
|
|
||
| // Weather or not the account is validated | ||
| /** Weather or not the account is validated */ |
src/pages/signin/SignInPage.js
Outdated
| validated: PropTypes.bool, | ||
|
|
||
| // Weather or not the account is validated | ||
| /** Weather or not the account is validated */ |
NikkiWines
reviewed
May 14, 2021
| onUpdateComment: PropTypes.func, | ||
|
|
||
| // comment value from IOUModal | ||
| /** comment value from IOUModal */ |
There was a problem hiding this comment.
NAB: should be capitalized
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
26 tasks
|
🚀 Deployed to staging in version: 1.0.46-1🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We updated the style guide to enforce block comments for
propTypesbut there are many not using that rule. This updates them all.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/151907
Tests
QA Steps
❌
Tested On
N/A
Screenshots
N/A