#2794 fix document attachment label

[dklymenk]

Details

Documentation for RNDocumentPicker says that the returned object has name and not fileName key.

Fixed Issues

Fixes #2794

Tests/QA Steps

PDF attachment:

1. Login in chat app.
2. Go to a conversation
3. Tap on the attachment icon
4. Tap on document
5. Select a PDF document.
6. You should see a preview

non-PDF non-image attachment:

1. Login in chat app.
2. Go to a conversation
3. Tap on the attachment icon
4. Tap on document
5. Select a non-PDF non-image file (I used .xsl).
6. You should see a preview with file name only.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

PDF

non-PDF non-image

Android

PDF

non-PDF non-image

[dklymenk]

The diff affects only one .native.js file, so to my understanding only iOS and Android should be tested.

Please let me know if I should add screenshots from other clients.

[chiragsalian]

Bump @thienlnam to review.

[thienlnam]

Tested IOS last friday (Worked well), currently running into issues with my android emulator so I will merge once I get that sorted out and tested

[thienlnam]

Nice, works as expected!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[kidroca]

This fixes the issue for the document picker but breaks it for the image picker as both use this function
one would call it with fileData that has fileName - image-picker results, the other with fileData that has just name
This should have been changed to

name: fileData.fileName || fileData.name || 'chat_attachment'

[dklymenk]

Ok, I agree.
@thienlnam , do you want me to create a new MR for this particular change or should this be a part of MR for this new issue @kidroca has created?

[thienlnam]

I'd recommend creating a new pull request with those changes, tag the new issue that @kidroca created and then add me as a reviewer on it

[dklymenk]

@thienlnam
Here is the PR. I can't manually add you to the list of reviewers.
#3408

Thanks