fix: tiny wording issue in REGRESSION_TEST_BEST_PRACTICES.md

[benomatis]

Correct tiny wording issue in REGRESSION_TEST_BEST_PRACTICES.md

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[melvin-bot]

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[benomatis]

I have read the CLA Document and I hereby sign the CLA

[marcochavezf]

Hi @benomatis, thanks for the suggestion, but you need to complete the checklist that appeared in the OP when the PR was created. Otherwise, I can't merge the PR

[benomatis]

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

[benomatis]

@marcochavezf A little bit of an overkill for this, but anyways, I posted the required checklist.

[marcochavezf]

Thanks @benomatis! It's just to make the checks happy and be able to merge without warnings

[marcochavezf]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1380.071 ms → 1459.499 ms (+79.428 ms, +5.8%) 🔴

Show details

Name

Duration

App start TTI

Baseline Mean: 1380.071 ms Stdev: 58.762 ms (4.3%) Runs: 1246.6702200002037 1255.4613569998182 1263.7141630002297 1275.0608799997717 1282.2772119999863 1288.206712000072 1298.7908210000023 1302.7509249998257 1303.1844279998913 1315.7901759999804 1316.0461349999532 1316.3673040000722 1317.8424729998223 1318.835173000116 1324.7679820000194 1325.0952730001882 1326.2793640000746 1329.575453999918 1333.3221300002187 1333.3735790001228 1333.5838449997827 1335.2693380001 1335.998228999786 1338.5498210000806 1339.3909410000779 1343.6120480000973 1345.253010999877 1345.9658929998986 1349.8065349999815 1353.6678840001114 1353.8316529998556 1364.9751829998568 1365.497173000127 1366.717947000172 1367.3349899998866 1367.5618400000967 1369.9830780001357 1370.3316660001874 1372.0839630002156 1372.388669999782 1375.0236869999208 1375.9139510001987 1381.0693600000814 1386.4079149998724 1387.2388169998303 1388.4719279999845 1388.9501760001294 1389.2944820001721 1389.895909999963 1391.5535929999314 1393.7691680002026 1394.3744430001825 1394.4085099999793 1396.0324559998699 1396.124055000022 1397.921480000019 1399.2982999999076 1400.8663960001431 1402.5785280000418 1402.7907250002027 1402.8002089997754 1407.243265000172 1407.889582999982 1409.4679939998314 1410.8790759998374 1412.4887810000218 1413.1816639997996 1416.3599780001678 1417.8862439999357 1422.2646820000373 1426.2237889999524 1429.8007430001162 1430.1755450000055 1431.8506439998746 1436.1070550000295 1436.2294760001823 1436.7086840001866 1437.811552000232 1438.4104599999264 1456.507182000205 1465.97057900019 1468.4853480001912 1489.9395650001243 1495.1981040001847 1504.0763440001756 1506.7151150000282 1515.4112700000405 1522.9549099998549 Current Mean: 1459.499 ms Stdev: 69.530 ms (4.8%) Runs: 1327.4160659997724 1338.9636369999498 1339.9652309999801 1341.0297179999761 1342.980008999817 1348.81505500013 1350.8846680000424 1353.4715459998697 1363.4991219998337 1363.5409340001643 1366.4906279998831 1366.506500000134 1373.9944110000506 1380.9588890001178 1386.376023999881 1386.439639000222 1390.5048750001006 1396.5639570001513 1401.4538819999434 1405.5494249998592 1406.2458219998516 1406.3471840000711 1410.3853989997879 1411.9900290002115 1415.1184749999084 1415.8871920001693 1416.4816510002129 1416.833891000133 1417.471942000091 1418.8546159998514 1419.3787400000729 1419.6581419999711 1421.3695000000298 1422.4658110002056 1422.5508440001868 1426.6052689999342 1427.9140420001931 1431.978937999811 1432.5420849998482 1442.3287979997694 1443.8559349998832 1451.7799379997887 1458.024422999937 1459.9678179998882 1462.7032900000922 1462.9884089999832 1468.7412189999595 1471.8352470002137 1475.7488779998384 1476.759347999934 1477.8526969999075 1479.2814719998278 1480.0035350001417 1480.1558119999245 1482.7842919998802 1483.4884500000626 1484.1241839998402 1486.092939000111 1492.1529250000603 1497.5750420000404 1498.3582709999755 1498.8191459998488 1502.6188539997675 1504.4433439997956 1504.5151769998483 1505.145138000138 1506.2837829999626 1509.4545020000078 1510.293095999863 1510.757505999878 1514.244752000086 1516.7953820000403 1519.1264180000871 1521.4067049999721 1523.4586000000127 1524.8876339998096 1526.8875890001655 1529.9009929997846 1534.3723729997873 1534.533747999929 1537.639903999865 1538.2690420001745 1556.8455599998124 1562.6966229998507 1563.9247790002264 1570.6666810000315 1580.1911749998108 1580.8276949999854 1590.869754999876 1598.558401999995 1633.8630030001514

Meaningless Changes To Duration

Show entries

Name	Duration
App start runJsBundle	962.058 ms → 996.516 ms (+34.458 ms, +3.6%)
Open Search Page TTI	665.756 ms → 682.024 ms (+16.267 ms, +2.4%)
App start nativeLaunch	22.216 ms → 24.080 ms (+1.865 ms, +8.4%)
App start regularAppStart	0.016 ms → 0.018 ms (+0.002 ms, +13.9%)

Show details

Name	Duration
App start runJsBundle	Baseline Mean: 962.058 ms Stdev: 48.104 ms (5.0%) Runs: 832 854 872 873 878 879 886 897 901 904 906 912 914 915 915 917 918 918 924 925 928 929 929 929 932 938 943 944 946 949 949 951 951 952 953 954 954 954 956 957 960 960 963 964 965 965 967 968 971 974 977 979 980 982 982 982 984 985 987 988 990 990 990 994 994 995 995 1001 1001 1002 1003 1004 1008 1011 1014 1014 1020 1029 1029 1030 1036 1039 1043 1047 1055 1082 Current Mean: 996.516 ms Stdev: 50.357 ms (5.1%) Runs: 877 900 903 904 908 911 916 921 923 931 933 933 935 938 938 938 942 942 945 946 952 954 954 957 963 968 969 970 970 972 974 976 978 979 980 982 982 988 994 995 995 996 996 997 999 1000 1002 1009 1013 1013 1015 1015 1016 1016 1016 1021 1022 1023 1024 1026 1027 1029 1029 1030 1033 1033 1033 1034 1035 1035 1037 1037 1040 1040 1043 1047 1048 1049 1049 1049 1050 1050 1052 1053 1054 1072 1073 1079 1081 1091 1116
Open Search Page TTI	Baseline Mean: 665.756 ms Stdev: 29.790 ms (4.5%) Runs: 613.7257489999756 618.1207280000672 619.1551109999418 621.8383379997686 624.5618900000118 627.2428390001878 628.1299649998546 628.8157139997929 631.4912109998986 631.563355000224 632.4013670003042 633.4484049999155 634.9394129998982 636.8468839996494 637.9537349999882 637.9641929999925 639.9423830001615 641.6163329998963 641.6363130002283 642.0113119999878 643.1291919997893 643.7116290000267 644.1940919999033 644.1943360003643 644.3050130000338 644.5538340001367 645.5734870000742 645.7828369997442 645.7830410003662 647.308960000053 648.2319340002723 648.5726320003159 649.0098060001619 649.7518319999799 651.6064050002024 651.6764739998616 651.878173999954 652.1640219995752 652.6971440003254 653.5186369996518 653.6035569999367 653.7119550001808 656.3768309997395 656.831135999877 658.2783210002817 658.4941000002436 658.8084720000625 659.6693110000342 660.1169849997386 661.9553629998118 664.3197429999709 665.9800220001489 667.2836099998094 668.3326420001686 671.7845049998723 672.6750900000334 673.7304690000601 674.6393229998648 675.0834960001521 676.0535890003666 676.3229170003906 678.3391119996086 678.8380940002389 681.5351980002597 681.9869389999658 684.247436999809 686.5402029999532 687.0694989999756 689.8187669999897 694.6499430001713 695.5225830003619 695.526368000079 696.3357750000432 696.6891279998235 697.6630859998986 700.6708169998601 705.4824230000377 706.7992759998888 707.5737709999084 707.7895510001108 708.4390059998259 708.4570309999399 708.7056479998864 713.443237000145 716.9337169998325 718.5157879996113 722.2159830001183 728.0469969999976 733.3050540001132 741.8297939999029 Current Mean: 682.024 ms Stdev: 21.857 ms (3.2%) Runs: 641.3103029998019 644.3074139999226 645.9915359998122 647.5701500000432 649.5881350003183 651.393351000268 651.5609949999489 653.5005289996043 655.6693520001136 655.8310139998794 656.2702639997005 657.4675290002488 658.2016610000283 658.3835040000267 659.1260169995949 660.9820149997249 661.5015869997442 661.8046059999615 662.3241779999807 662.6517749996856 663.759724999778 664.6424159999005 665.7855229997076 666.6547039998695 667.3730469997972 667.4638269999996 667.980835000053 668.6097009996884 668.991088999901 669.8113200003281 670.0091559998691 672.48384599993 673.1918540000916 674.2881679995917 674.9779460001737 675.7368169999681 675.7644450003281 676.0553800002672 676.2277019997127 677.6241059997119 678.1300059999339 679.5767410001718 679.768880000338 679.8115649996325 680.0466310000047 680.8038329998963 681.0050050001591 681.0484209996648 681.3479419997893 681.3796800002456 682.4456380000338 683.4853520002216 683.7851559999399 684.5447180001065 684.9383950000629 685.8964840001427 686.0967199997976 688.6537279998884 690.363322999794 691.5362550001591 692.7299810000695 693.1165370000526 693.2472740001976 694.6746430001222 694.7095539998263 695.3513999995776 695.8032639999874 697.8684899997897 698.2490650000982 700.3361819996499 700.3740639998578 700.802449000068 700.9954029996879 703.5941580003127 703.8994140001014 706.4868169999681 707.2030030000024 707.4072669995949 708.8380539999343 714.2537039997987 714.7747400002554 714.8784179999493 715.0519210002385 719.1061200001277 725.1293950001709 725.8836670001037 727.0863860002719 728.5944010000676 742.1342369997874
App start nativeLaunch	Baseline Mean: 22.216 ms Stdev: 2.814 ms (12.7%) Runs: 18 18 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 25 25 26 26 26 26 28 28 28 29 29 29 30 30 Current Mean: 24.080 ms Stdev: 2.543 ms (10.6%) Runs: 20 20 20 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 24 24 24 25 25 25 25 25 25 25 25 25 25 25 25 25 26 26 26 26 26 26 27 27 27 27 27 28 28 28 29 29 29 31 31 32
App start regularAppStart	Baseline Mean: 0.016 ms Stdev: 0.001 ms (6.8%) Runs: 0.013264999724924564 0.0138349998742342 0.013916000258177519 0.013956999871879816 0.014282000251114368 0.014322999864816666 0.014405000023543835 0.014485999941825867 0.014688999857753515 0.014688999857753515 0.01472900016233325 0.014810999855399132 0.014812000095844269 0.014932999853044748 0.014934000093489885 0.014973999932408333 0.01501399977132678 0.015054999850690365 0.015056000091135502 0.01509599993005395 0.015135999768972397 0.015137000009417534 0.015176999848335981 0.015300000086426735 0.01537999976426363 0.015381000004708767 0.015381000004708767 0.015420999843627214 0.015421000309288502 0.015422000084072351 0.015503000002354383 0.015583999920636415 0.015625 0.015625 0.015625 0.01570600038394332 0.01570700015872717 0.015746999997645617 0.015747999772429466 0.015748000238090754 0.01582799991592765 0.015910000074654818 0.015949999913573265 0.015950999688357115 0.016032000072300434 0.016032000072300434 0.01607299968600273 0.01607300015166402 0.016112999990582466 0.016153999604284763 0.016234999988228083 0.01627599960193038 0.016276000067591667 0.016276000067591667 0.016315999906510115 0.016397999599575996 0.016439000144600868 0.016478999983519316 0.016480000223964453 0.0165200000628829 0.0165200000628829 0.016521000303328037 0.016561000142246485 0.016600999981164932 0.016682999674230814 0.01680499967187643 0.016805000137537718 0.016844999976456165 0.01688600005581975 0.0168869998306036 0.016887000296264887 0.016927000135183334 0.016966999974101782 0.01696800021454692 0.01704900013282895 0.017130000051110983 0.017130999825894833 0.01713100029155612 0.017212000209838152 0.01733399974182248 0.017659000121057034 0.01798499980941415 0.0185139998793602 0.0186769999563694 0.019164999946951866 Current Mean: 0.018 ms Stdev: 0.001 ms (6.9%) Runs: 0.015746999997645617 0.01599099999293685 0.016276000067591667 0.016276999842375517 0.0163569999858737 0.016358000226318836 0.016398000065237284 0.016439000144600868 0.0165200000628829 0.01660200022161007 0.01660200022161007 0.01660200022161007 0.01672299997881055 0.0167239997535944 0.0167239997535944 0.0167239997535944 0.016764000058174133 0.01700799958780408 0.017089999746531248 0.017130000051110983 0.017130000051110983 0.017130999825894833 0.01713100029155612 0.017172000370919704 0.0172520000487566 0.0172520000487566 0.017253000289201736 0.017374000046402216 0.017455999739468098 0.017456000205129385 0.017537000123411417 0.017577999737113714 0.01757899997755885 0.01761799957603216 0.017659000121057034 0.017659000121057034 0.017700000200420618 0.017821999732404947 0.01786300027742982 0.01786300027742982 0.01790299965068698 0.01794400019571185 0.01798499980941415 0.018106999807059765 0.0181470001116395 0.01814799988642335 0.01814799988642335 0.018309999722987413 0.018352000042796135 0.018432000186294317 0.01847400004044175 0.018635999877005816 0.018635999877005816 0.01867600018158555 0.018716999795287848 0.018717000260949135 0.018718000035732985 0.018718000035732985 0.018838999792933464 0.01887999987229705 0.018881000112742186 0.018920000176876783 0.018920999951660633 0.01896099979057908 0.018961000256240368 0.019001999869942665 0.019084000028669834 0.019164999946951866 0.01920600002631545 0.019246000330895185 0.019247000105679035 0.019328000023961067 0.01936900010332465 0.0194089999422431 0.019450000021606684 0.01948999986052513 0.019530999939888716 0.019531000405550003 0.019652999937534332 0.0197350000962615 0.019816000014543533 0.01993800001218915 0.02002000017091632 0.020061000250279903 0.020100999623537064 0.020182000007480383 0.0211990000680089 0.021809999831020832

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅