[NoQA] [Wave 8 - ECard Transactions] Create `eReceiptThumbnail` and `eReceipt` components #29075

grgia · 2023-10-09T10:02:35Z

Details

It creates (but does not use) the eReceipt Thumbnail and eReceipt Components. This will be used as the "image" preview for eReceipts in the Report Preview.

This is how it is going to be used later:

This PR uses styles from https://github.com/Expensify/App/pull/27204/files

Fixed Issues

$ #28826
$ #28828

Tests

Verify that no errors appear in the JS console
I added a story and built in storybook.

Screen.Recording.2023-10-09.at.12.09.47.PM.mov

I added a story and built in storybook.

Note: storybook was not updating with styles.js, see screenshots from web for correct currency font size

Screen.Recording.2023-10-07.at.7.40.09.PM.mov

I added the component to a random page and tested with some fake ONYX data via console:

To display the full eReceipt, the user must have both the transaction and the card in the cardList

Onyx.merge('transactions_1', {amount: 1000, currency: 'USD', cardID: 4, merchant: "United Airlines", mccGroup: "Airlines", created: "2023-07-24 13:46:20"});


Onyx.merge('cardList',
{
  4: {
    "bank": 'Expensify Card',
    "lastFourPAN": '1000',
   }
);

QA Steps

NO QA

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

cloudflare-workers-and-pages · 2023-10-09T10:36:40Z

Deploying with Cloudflare Pages

Latest commit:	`b8c3300`
Status:	✅ Deploy successful!
Preview URL:	https://31c90cd5.helpdot.pages.dev
Branch Preview URL:	https://georgia-cardtransactionserec-y44f.helpdot.pages.dev

View logs

shawnborton · 2023-10-09T12:44:38Z

Nice, this feels pretty good to me! One thing we were doing in the mockups though was to create some variance by moving around the location of the background image:

Is that something we can still do? I think we can just make it so that each particular colorway (the 6 shown above) get their own background image.

grgia · 2023-10-09T20:05:17Z

Hey @fedirjh this is failing travis due to storybook changes, I think it's unrelated to this PR and no one has updated storybook in awhile. Would you want to do a code review now? We are not using them in App.

**note: **
AFAIK Storybook isn't set up for connecting to onyx so the MCC icon will not appear (due to nested EReceiptThumbnail, but you can see they work in the EReceiptThumbnail stories). Also, the card program name will not appear (from cardList)

fedirjh · 2023-10-09T20:51:38Z

Reviewing shortly.

assets/images/MCCGroupIcons/MCC-Airlines.svg

src/components/EReceiptThumbnail.js

src/libs/ReportUtils.js

src/components/EReceipt.js

grgia · 2023-10-11T09:53:32Z

@Li357 bump on final review! Wave 8 :)

src/components/EReceipt.js

src/libs/ReportUtils.js

src/components/EReceipt.js

src/components/EReceiptThumbnail.js

mountiny · 2023-10-11T17:56:49Z

src/components/EReceiptThumbnail.js

+    return backgroundImages[StyleUtils.getEReceiptColorCode(transaction)];
+}
+
+function EReceiptThumbnail({transaction}) {


Yeah but dont we have to add it here same as you have it in the eReceipt.js?

I felt like the transactionID should be here too, but its not used in the component and for withOnyx its enough when mentioned in the propTypes. so no problem

mountiny

Thanks!

Li357 · 2023-10-11T19:41:24Z

src/styles/StyleUtils.ts

-    {backgroundColor: colors.green800, color: colors.green400},
-    {backgroundColor: colors.tangerine800, color: colors.tangerine400},
-    {backgroundColor: colors.pink800, color: colors.pink400},
+const eReceiptColorStyles: Partial<Record<EReceiptColorName, EreceiptColorStyle>> = {


NAB: EreceiptColorStyle -> EReceiptColorStyle

OSBotify · 2023-10-11T22:30:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:55:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:07:41Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:23:55Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:59:19Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

jjcoffee · 2024-02-16T15:37:41Z

src/components/EReceiptThumbnail.js

+    const [containerWidth, setContainerWidth] = useState(0);
+    const [containerHeight, setContainerHeight] = useState(0);
+
+    const onContainerLayout = (event) => {


Coming from #34316, onContainerLayout will give the correct values to the state only once the page is rendered and is a few seconds late, so there's a flicker of the previous page's thumbnail size when navigating between views. More info in the proposal here.

grgia added 7 commits October 7, 2023 11:59

Fix mcc svgs and initial sketch commit of EReceipt

be2d3f0

Fix spacing so text can expand

fc93b9a

Grabbing transaction info

019b12a

Use transaction data for eReceipt

860e34a

Fix cardID is number not string

115579d

prettier

a9b32e0

Initial Draft of Ereceiptpreview

ae4a105

grgia self-assigned this Oct 9, 2023

Clean up MCCs

50cfb5c

grgia added the Design label Oct 9, 2023

grgia requested a review from shawnborton October 9, 2023 11:12

Disable props spreading in stories

6396515

grgia changed the title ~~card transactions ereceipt preview~~ Create eReceipt Thumbnail component Oct 9, 2023

grgia added 2 commits October 9, 2023 12:39

mcc fill

98616ef

remove test from preferences page

1c5e042

grgia mentioned this pull request Oct 9, 2023

Create eReceipt Component #29054

Closed

61 tasks

grgia added 2 commits October 9, 2023 19:24

Use PNGs

9ce3005

prettier

5ef5ab4

grgia changed the title ~~Create eReceipt Thumbnail component~~ Create eReceiptThumbnail and eReceipt component Oct 9, 2023

lint

c005b3d

grgia requested a review from fedirjh October 9, 2023 19:33

Use Thumbnail in Ereceipt component

d56ab9a

fedirjh reviewed Oct 9, 2023

View reviewed changes

assets/images/MCCGroupIcons/MCC-Airlines.svg Outdated Show resolved Hide resolved

fedirjh reviewed Oct 9, 2023

View reviewed changes

src/components/EReceiptThumbnail.js Outdated Show resolved Hide resolved

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

src/libs/ReportUtils.js Show resolved Hide resolved

src/components/EReceipt.js Outdated Show resolved Hide resolved

grgia added 2 commits October 10, 2023 10:36

Merge branch 'main' into georgia-cardTransactionsEReceiptPreview

7ea7587

add back waypoints

fc318a7

grgia changed the title ~~Create eReceiptThumbnail and eReceipt component~~ [Wave 8 - ECard Transactions] Create eReceiptThumbnail and eReceipt components Oct 11, 2023

mountiny changed the title ~~[Wave 8 - ECard Transactions] Create eReceiptThumbnail and eReceipt components~~ [NoQA] [Wave 8 - ECard Transactions] Create eReceiptThumbnail and eReceipt components Oct 11, 2023

mountiny reviewed Oct 11, 2023

View reviewed changes

src/components/EReceipt.js Show resolved Hide resolved

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

mountiny reviewed Oct 11, 2023

View reviewed changes

src/components/EReceipt.js Outdated Show resolved Hide resolved

mountiny reviewed Oct 11, 2023

View reviewed changes

src/components/EReceiptThumbnail.js Show resolved Hide resolved

grgia commented Oct 11, 2023

View reviewed changes

src/components/EReceiptThumbnail.js Show resolved Hide resolved

date fix

a169ff8

grgia requested a review from mountiny October 11, 2023 16:18

mountiny reviewed Oct 11, 2023

View reviewed changes

remove normal line height, this will break IOS

da89fc5

mountiny approved these changes Oct 11, 2023

View reviewed changes

Merge branch 'main' into georgia-cardTransactionsEReceiptPreview

b8c3300

Li357 reviewed Oct 11, 2023

View reviewed changes

Li357 approved these changes Oct 11, 2023

View reviewed changes

grgia merged commit ff3c7b2 into main Oct 11, 2023

grgia deleted the georgia-cardTransactionsEReceiptPreview branch October 11, 2023 22:24

mountiny mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

JKobrynski mentioned this pull request Jan 2, 2024

[TS Migration] Migrate EReceiptThumbnail.js component to TypeScript #32913

Merged

50 tasks

jjcoffee mentioned this pull request Jan 24, 2024

[HOLD for payment 2024-02-07] [$500] Android - Center icon in EReceipt for Expensify transactions is blank #34907

Closed

6 tasks

jjcoffee reviewed Feb 16, 2024

View reviewed changes

jjcoffee mentioned this pull request Feb 16, 2024

[HOLD for payment 2024-02-20] [$500] EReceipt - Center icon in preview moves or changes in size when switching pages #34316

Closed

6 tasks

jayeshmangwani mentioned this pull request Jan 2, 2025

[HOLD for payment 2025-01-30] [$250] EReceipt thumbnail is being cut off at the bottom. #54772

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] [Wave 8 - ECard Transactions] Create `eReceiptThumbnail` and `eReceipt` components #29075

[NoQA] [Wave 8 - ECard Transactions] Create `eReceiptThumbnail` and `eReceipt` components #29075

grgia commented Oct 9, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 9, 2023 •

edited

Loading

shawnborton commented Oct 9, 2023

grgia commented Oct 9, 2023

fedirjh commented Oct 9, 2023

grgia commented Oct 11, 2023

mountiny Oct 11, 2023

grgia Oct 11, 2023

mountiny Oct 11, 2023

mountiny left a comment

Li357 Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

jjcoffee Feb 16, 2024

[NoQA] [Wave 8 - ECard Transactions] Create eReceiptThumbnail and eReceipt components #29075

[NoQA] [Wave 8 - ECard Transactions] Create eReceiptThumbnail and eReceipt components #29075

Conversation

grgia commented Oct 9, 2023 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

cloudflare-workers-and-pages bot commented Oct 9, 2023 • edited Loading

Deploying with Cloudflare Pages

shawnborton commented Oct 9, 2023

grgia commented Oct 9, 2023

fedirjh commented Oct 9, 2023

grgia commented Oct 11, 2023

mountiny Oct 11, 2023

Choose a reason for hiding this comment

grgia Oct 11, 2023

Choose a reason for hiding this comment

mountiny Oct 11, 2023

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

Li357 Oct 11, 2023

Choose a reason for hiding this comment

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

jjcoffee Feb 16, 2024

Choose a reason for hiding this comment

[NoQA] [Wave 8 - ECard Transactions] Create `eReceiptThumbnail` and `eReceipt` components #29075

[NoQA] [Wave 8 - ECard Transactions] Create `eReceiptThumbnail` and `eReceipt` components #29075

grgia commented Oct 9, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 9, 2023 •

edited

Loading