Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong argument name give to automerge-action #2887

Merged
merged 1 commit into from
May 13, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented May 13, 2021

Fixing https://github.com/Expensify/Expensify/issues/157916
Following-up on #2329
Sneaky silent failed workflow run: https://github.com/Expensify/Expensify.cash/runs/2579087959?check_suite_focus=true

What happened: argument name given to automerge-action should have been just PULL_REQUEST, not PULL_REQUEST_NUMBER

image

@roryabraham roryabraham requested a review from Jag96 May 13, 2021 21:36
@roryabraham roryabraham self-assigned this May 13, 2021
@roryabraham roryabraham requested a review from a team as a code owner May 13, 2021 21:36
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team May 13, 2021 21:36
@Jag96 Jag96 merged commit f98d269 into main May 13, 2021
@Jag96 Jag96 deleted the Rory-FixArgumentsToAutomerge branch May 13, 2021 21:46
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.43-9🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants