Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2806 fix selectable timezone dropdown with thuthy disabled passed #2824

Merged
merged 3 commits into from
May 14, 2021
Merged

#2806 fix selectable timezone dropdown with thuthy disabled passed #2824

merged 3 commits into from
May 14, 2021

Conversation

dklymenk
Copy link
Contributor

@dklymenk dklymenk commented May 12, 2021 •
edited
Loading

Details

Fixed Issues

Fixes #2806

Tests / QA Steps

  1. Go to Setting - Profile
  2. Scroll down to Time zone field
  3. Set my time zone automatically should be selected
  4. The time zone picker should be disabled (clicking on it must not bring up any options)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

DeepinScreenshot_select-area_20210513132039

Mobile Web

DeepinScreenshot_select-area_20210513132049

Desktop

Screen Shot 2021-05-13 at 13 25 58

iOS

Screen Shot 2021-05-13 at 13 25 06

Android

DeepinScreenshot_select-area_20210513132012

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dklymenk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dklymenk dklymenk mentioned this pull request May 12, 2021
Closed
@dklymenk dklymenk marked this pull request as ready for review May 13, 2021 10:31
@dklymenk dklymenk requested a review from a team as a code owner May 13, 2021 10:31
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team May 13, 2021 10:31
@dklymenk
Copy link
Contributor Author

Tested on all platforms and added screenshots

@marcaaron marcaaron self-requested a review May 13, 2021 17:49
marcaaron
marcaaron previously approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM all yours @NikkiWines

NikkiWines
NikkiWines previously approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the CLA issue this looks good - tested and works well

@NikkiWines
Copy link
Contributor

@dklymenk looks like you have some conflcits

@dklymenk dklymenk dismissed stale reviews from NikkiWines and marcaaron via 75b3b55 May 14, 2021 22:40
@dklymenk
Copy link
Contributor Author

@NikkiWines Conflict's fixed. I think the comment style got changed in the file, so I changed mine too. No other changes.

NikkiWines
NikkiWines approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines NikkiWines merged commit 09f0059 into Expensify:main May 14, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 14, 2021
Closed
26 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.46-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@marcaaron marcaaron marcaaron left review comments

Assignees

@dklymenk dklymenk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timezone - Dropdown is selectable when the "Set my time zone" bottom checkbox is checked
4 participants
@dklymenk @NikkiWines @OSBotify @marcaaron