Added dynamic repositioning for Context menu on resize #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasharrajat
commented
May 12, 2021
parasharrajat
commented
May 12, 2021
parasharrajat
commented
May 12, 2021
thienlnam
requested changes
May 12, 2021
|
Updated. |
|
Changes look good, going to give it a test run |
thienlnam
approved these changes
May 14, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
26 tasks
|
🚀 Deployed to staging in version: 1.0.46-1🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review
Details
Fixed Issues
Fixes #2784
Tests \ QA Steps
Test 1
Resize the browser to see if the context menu is moved along.
Test 2
Right-click any message near the edge of the window. The menu should be completely visible.
Tested On
Screenshots
Web / Desktop
move-context.mp4