feat(workspace-settings): currency selector push to page #27861

thiagobrez · 2023-09-20T13:14:06Z

Details

Convert the Workspace Settings Currency Selector to Push-to-page pattern.

Fixed Issues

$ #25499
PROPOSAL:

Tests

Verify that no errors appear in the JS console

In Workspace -> Settings:

Press the selected currency. Instead of the native browser options picker, a new page should animate on top
The current selected currency should appear selected and highlighted
User should be able to use arrow keys to move up and down the list
Pressing Enter should select the highlighted item
Typing into the text input at the top should filter the list
Selecting an item, either pressing or with Enter key, should navigate the page back to Workspace Settings. The new item should appear in the menu as the new default

Offline tests

QA Steps

Verify that no errors appear in the JS console

In Workspace -> Settings:

Press the selected currency. Instead of the native browser options picker, a new page should animate on top
The current selected currency should appear selected and highlighted
User should be able to use arrow keys to move up and down the list
Pressing Enter should select the highlighted item
Typing into the text input at the top should filter the list
Selecting an item, either pressing or with Enter key, should navigate the page back to Workspace Settings. The new item should appear in the menu as the new default

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.web.mov

Mobile Web - Safari

ios.web.mp4

Desktop

desktop.mov

iOS

ios.native.mp4

Android

android.native.mov

rezkiy37

LGTM, left a few comments.

src/pages/workspace/WorkspaceSettingsCurrencyPage.js

src/pages/workspace/WorkspaceSettingsPage.js

src/pages/workspace/WorkspaceSettingsCurrencyPage.js

src/pages/workspace/WorkspaceSettingsPage.js

melvin-bot · 2023-09-21T11:10:21Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thiagobrez · 2023-09-21T15:40:03Z

Heads up: I'll be OOO from tomorrow until Tuesday - if needed, someone from Callstack can continue here!

abdulrahuman5196 · 2023-09-27T05:12:21Z

@thiagobrez Could you kindly fix the merge conflicts?

thiagobrez · 2023-09-27T13:04:08Z

Hey @abdulrahuman5196! It's done. Please be aware that currencies are not loading due to a regression in dev, not related to this PR. If you enter the Request Money page in development and try to select a currency, that list is gonna be empty. Also, this same workspace settings currency selector is empty, so the currencyList is not loading correctly

These bug reports on #expensify-bugs seem to be related, so we should have a issue to put this on hold soon:

abdulrahuman5196 · 2023-09-27T15:06:46Z

Thank you for the update @thiagobrez . Then kindly let me know once we can have a review on this PR.

…to-page

thiagobrez · 2023-09-29T09:17:22Z

Sent a question here: https://expensify.slack.com/archives/C01GTK53T8Q/p1695976576047759

thiagobrez · 2023-10-03T14:15:23Z

Still blocked, trying to get answers in the thread linked above

thiagobrez · 2023-10-03T14:20:33Z

@abdulrahuman5196 This is not blocked, it was corrupted data in my local storage 🤦🏻 you're free to go ahead and test!

abdulrahuman5196 · 2023-10-04T18:21:28Z

Unit Tests are failing here. I think you need to do a merge from main if the tests are not failing related to this PR. @thiagobrez

…to-page

thiagobrez · 2023-10-05T08:06:05Z

@abdulrahuman5196 done!

abdulrahuman5196 · 2023-10-05T09:35:38Z

@thiagobrez
If we provide wrong workspace url, it is leading to the current selection but on selection it is leading to page not found view.
But even the currency selection should have shown page not view similarly not allowing user to select currency

Screen.Recording.2023-10-05.at.3.02.57.PM.mov

thiagobrez · 2023-10-06T08:25:37Z

Nice catch @abdulrahuman5196! It's fixed, please check again when you have time

abdulrahuman5196 · 2023-10-10T17:23:14Z

Code looks good to me. Will do platforms testing tomorrow.

abdulrahuman5196 · 2023-10-11T13:54:27Z

Reviewing now

abdulrahuman5196 · 2023-10-11T14:38:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-11.at.7.32.13.PM.mp4

Mobile Web - Chrome

Screen.Recording.2023-10-11.at.7.41.29.PM.mp4

Mobile Web - Safari

Screen.Recording.2023-10-11.at.7.38.03.PM.mp4

Desktop

Screen.Recording.2023-10-11.at.8.02.44.PM.mp4

iOS

Screen.Recording.2023-10-11.at.7.53.29.PM.mp4

Android

Screen.Recording.2023-10-11.at.7.58.50.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @grgia

🎀 👀 🎀
C+ Reviewed

OSBotify · 2023-10-11T17:52:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:57:08Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:09:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:25:25Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:00:48Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

parasharrajat · 2024-05-09T15:52:00Z

It looks like we didn't use a proper searching technique to find the currencies on the CurrencySelection page which missed the case mentioned on #29618

thiagobrez added 2 commits September 20, 2023 13:51

feat(workspace-settings): currency selector push to page

9b4818e

chore: cleanup

4847ec4

rezkiy37 reviewed Sep 20, 2023

View reviewed changes

adhorodyski reviewed Sep 20, 2023

View reviewed changes

src/pages/workspace/WorkspaceSettingsCurrencyPage.js Outdated Show resolved Hide resolved

barttom reviewed Sep 20, 2023

View reviewed changes

thiagobrez added 2 commits September 20, 2023 15:28

chore: address pr comments

2f2286d

chore: cleanup

f7ca607

fabioh8010 reviewed Sep 20, 2023

View reviewed changes

src/pages/workspace/WorkspaceSettingsCurrencyPage.js Show resolved Hide resolved

src/pages/workspace/WorkspaceSettingsCurrencyPage.js Show resolved Hide resolved

pac-guerreiro reviewed Sep 20, 2023

View reviewed changes

thiagobrez added 2 commits September 20, 2023 18:16

chore: address pr comments

5539242

chore: fix submit button style

43140ea

thiagobrez marked this pull request as ready for review September 21, 2023 11:10

thiagobrez requested a review from a team as a code owner September 21, 2023 11:10

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team September 21, 2023 11:10

thiagobrez mentioned this pull request Sep 21, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Convert Workspace Currency Selector to use Push to Page Pattern #25499

Closed

chore: cleanup

86b650f

This was referenced Sep 21, 2023

[Tracker] Selection List Refactor #11795

Closed

LOW: [$500] Selection List Refactor: Simple Selection List #20354

Closed

thiagobrez added 3 commits September 27, 2023 11:05

chore: fix conflicts

f8635a1

chore: fix get route calls

4dff71d

chore: fix linkingConfig and empty currencyList

a470400

Merge branch 'main' into thiagobrez/workspace-currency-selector-push-…

caed2e5

…to-page

Merge branch 'main' into thiagobrez/workspace-currency-selector-push-…

5076fc5

…to-page

chore: fix lint

50ee3a8

feat(workspace-settings): currency page offline view

c559c5c

abdulrahuman5196 approved these changes Oct 11, 2023

View reviewed changes

melvin-bot bot requested a review from grgia October 11, 2023 14:45

grgia approved these changes Oct 11, 2023

View reviewed changes

grgia merged commit b820046 into Expensify:main Oct 11, 2023

mountiny mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

Pujan92 mentioned this pull request Oct 20, 2023

[HOLD for payment 2024-05-09] [$500] Currency - In WS default currency section searching for euro/rupee showing "no results found" #29618

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(workspace-settings): currency selector push to page #27861

feat(workspace-settings): currency selector push to page #27861

thiagobrez commented Sep 20, 2023 •

edited

Loading

rezkiy37 left a comment

melvin-bot bot commented Sep 21, 2023

thiagobrez commented Sep 21, 2023

abdulrahuman5196 commented Sep 27, 2023

thiagobrez commented Sep 27, 2023

abdulrahuman5196 commented Sep 27, 2023

thiagobrez commented Sep 29, 2023

thiagobrez commented Oct 3, 2023

thiagobrez commented Oct 3, 2023

abdulrahuman5196 commented Oct 4, 2023

thiagobrez commented Oct 5, 2023

abdulrahuman5196 commented Oct 5, 2023

thiagobrez commented Oct 6, 2023

abdulrahuman5196 commented Oct 10, 2023

abdulrahuman5196 commented Oct 11, 2023

abdulrahuman5196 commented Oct 11, 2023 •

edited

Loading

abdulrahuman5196 left a comment

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

parasharrajat commented May 9, 2024

feat(workspace-settings): currency selector push to page #27861

feat(workspace-settings): currency selector push to page #27861

Conversation

thiagobrez commented Sep 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 21, 2023

thiagobrez commented Sep 21, 2023

abdulrahuman5196 commented Sep 27, 2023

thiagobrez commented Sep 27, 2023

abdulrahuman5196 commented Sep 27, 2023

thiagobrez commented Sep 29, 2023

thiagobrez commented Oct 3, 2023

thiagobrez commented Oct 3, 2023

abdulrahuman5196 commented Oct 4, 2023

thiagobrez commented Oct 5, 2023

abdulrahuman5196 commented Oct 5, 2023

thiagobrez commented Oct 6, 2023

abdulrahuman5196 commented Oct 10, 2023

abdulrahuman5196 commented Oct 11, 2023

abdulrahuman5196 commented Oct 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

parasharrajat commented May 9, 2024

thiagobrez commented Sep 20, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 11, 2023 •

edited

Loading