Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #2773

Merged
merged 1 commit into from
May 11, 2021
Merged

Update CONTRIBUTING.md #2773

merged 1 commit into from
May 11, 2021

Conversation

arielgreen
Copy link
Contributor

Details

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/163447

Tests

None

QA Steps

Review https://github.com/Expensify/Expensify.cash/blob/main/CONTRIBUTING.md and ensure that "5. Add AutoAssignerTriage label to issue is added under the section on "Proposing a job that Expensify hasn’t posted"

@arielgreen arielgreen requested review from roryabraham and a team May 10, 2021 23:01
@arielgreen arielgreen self-assigned this May 10, 2021
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team May 10, 2021 23:02
@arielgreen arielgreen requested review from Beamanator and removed request for roryabraham May 10, 2021 23:05
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :D

@Beamanator Beamanator merged commit b2025d7 into main May 11, 2021
@Beamanator Beamanator deleted the arielgreen-patch-1 branch May 11, 2021 10:55
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.41-10🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants