[No QA] Fix parsing bug in getStagingDeployCash #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
May 10, 2021
36 tasks
|
🚀 Deployed to staging in version: 1.0.41-6🚀
|
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndrewGable will you please review this?
Details
We've had a number of failed workflows (example), and as a result our deploy checklist has not been updating. That's because it was created under unusual circumstances, where no PRs were merged while the previous StagingDeployCash was locked, so there were no PRs to add to the issue description for the new checklist.
Fixed Issues
n/a
Tests
Added a unit test by copying the body of the current StagingDeployCash checklist.
QA Steps
none
Tested On